Stork observability #35934

aureamunoz · 2023-09-14T15:16:54Z

No description provided.

quarkus-bot · 2023-09-14T15:17:15Z

/cc @brunobat (micrometer), @ebullient (micrometer)

extensions/micrometer/runtime/pom.xml

integration-tests/rest-client-reactive-stork/src/main/resources/application.properties

.../src/main/java/io/quarkus/micrometer/runtime/binder/stork/StorkObservationCollectorBean.java

...r/deployment/src/main/java/io/quarkus/micrometer/deployment/binder/StorkBinderProcessor.java

...ployment/src/test/java/io/quarkus/micrometer/deployment/binder/StorkMetricsDisabledTest.java

...meter/deployment/src/test/java/io/quarkus/micrometer/deployment/binder/StorkMetricsTest.java

.../src/main/java/io/quarkus/micrometer/runtime/binder/stork/StorkObservationCollectorBean.java

...llrye-stork/runtime/src/main/java/io/quarkus/stork/QuarkusStorkObservableInfrastructure.java

.../src/main/java/io/quarkus/micrometer/runtime/binder/stork/StorkObservationCollectorBean.java

cescoffier

Awesome! a few things to change, but nothing major (and enjoy your long weekend @aureamunoz )

docs/src/main/asciidoc/stork-reference.adoc

.../test/java/io/quarkus/micrometer/deployment/binder/StorkMetricsServiceDiscoveryFailTest.java

...meter/deployment/src/test/java/io/quarkus/micrometer/deployment/binder/StorkMetricsTest.java

aureamunoz · 2023-10-16T08:40:22Z

Thanks for the review @cescoffier. I've just pushed the suggested changes. Let's see what CI says

github-actions · 2023-10-16T20:55:22Z

🙈 The PR is closed and the preview is expired.

cescoffier

Can you rebase to see if the CI still fails on micrometer?

gsmet · 2023-10-18T08:54:28Z

I don't think we should rebase, please have a look at the tests first locally as it seems they are failing for all JDKs which is highly suspicious.

brunobat

We are probably missing an integration test project to make sure the produced metrics values make sense and can be maintained in the future with minimal impact.

docs/src/main/asciidoc/stork-reference.adoc

quarkus-bot · 2023-10-23T17:00:15Z

Failing Jobs - Building `ebbcf7c`

Status	Name	Step	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 17	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 17 Windows	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 20	`Build`	⚠️ Check →	Logs	Raw logs
✔️	Maven Tests - JDK 11
✖	Maven Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs
✖	Native Tests - Messaging1	`Build`	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/hibernate-orm/deployment extensions/oidc-client-graphql/deployment 
! Skipped: extensions/flyway/deployment extensions/hibernate-envers/deployment extensions/hibernate-reactive/deployment and 102 more

📦 extensions/hibernate-orm/deployment

✖ Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.1.2:test (default-test) on project quarkus-hibernate-orm-deployment:

Please refer to /home/runner/work/quarkus/quarkus/extensions/hibernate-orm/deployment/target/surefire-reports for the individual test results. Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream. There was an error in the forked process

📦 extensions/oidc-client-graphql/deployment

✖ io.quarkus.oidc.client.graphql.GraphQLClientUsingOidcClientTest.dynamicClientWithDefault line 58 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/oidc-client-graphql/deployment

📦 extensions/oidc-client-graphql/deployment

✖ io.quarkus.oidc.client.graphql.GraphQLClientUsingOidcClientTest.dynamicClientWithDefault line 58 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

⚙️ JVM Tests - JDK 17 Windows #

- Failing: extensions/vertx-http/deployment 
! Skipped: devtools/cli extensions/agroal/deployment extensions/amazon-lambda-http/deployment and 364 more

📦 extensions/vertx-http/deployment

✖ io.quarkus.vertx.http.proxy.TrustedForwarderProxyFailureTest.testHeadersAreIgnored line 29 - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/sun.nio.ch.NioSocketImpl.timedRead(NioSocketImpl.java:288)
	at java.base/sun.nio.ch.NioSocketImpl.implRead(NioSocketImpl.java:314)

✖ io.quarkus.vertx.http.proxy.TrustedXForwarderProxiesUnknownHostnameFailureTest.testHeadersAreIgnored line 17 - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/sun.nio.ch.NioSocketImpl.timedRead(NioSocketImpl.java:288)
	at java.base/sun.nio.ch.NioSocketImpl.implRead(NioSocketImpl.java:314)

⚙️ Maven Tests - JDK 11 Windows #

📦 integration-tests/maven

✖ io.quarkus.maven.it.DevMojoIT.testConfigFactoryInAppModuleBannedInCodeGen line 78 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.maven.it.DevMojoIT.testConfigFactoryInAppModuleBannedInCodeGen line 78 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.maven.it.DevMojoIT.testExternalReloadableArtifacts line 1448 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.DevMojoIT was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.maven.it.DevMojoIT.testExternalReloadableArtifacts line 1448 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.DevMojoIT was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.maven.it.JarRunnerIT.testNonAsciiDir line 70 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.maven.it.JarRunnerIT.testNonAsciiDir line 70 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.maven.it.JarRunnerIT.testPlatformPropertiesOverridenInApplicationProperties line 135 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.JarRunnerIT that uses io.quarkus.maven.it.verifier.MavenProcessInvocationResult was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.maven.it.JarRunnerIT.testPlatformPropertiesOverridenInApplicationProperties line 135 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.JarRunnerIT that uses io.quarkus.maven.it.verifier.MavenProcessInvocationResult was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

⚙️ Native Tests - Messaging1 #

- Failing: integration-tests/kafka-oauth-keycloak

📦 integration-tests/kafka-oauth-keycloak

✖ Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:build (default) on project quarkus-integration-test-kafka-oauth-keycloak: Failed to build quarkus application

quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/metrics area/smallrye area/stork labels Sep 14, 2023

cescoffier requested changes Sep 14, 2023

View reviewed changes

extensions/micrometer/runtime/pom.xml Show resolved Hide resolved

extensions/micrometer/runtime/pom.xml Show resolved Hide resolved

integration-tests/rest-client-reactive-stork/src/main/resources/application.properties Outdated Show resolved Hide resolved

brunobat reviewed Sep 14, 2023

View reviewed changes

.../src/main/java/io/quarkus/micrometer/runtime/binder/stork/StorkObservationCollectorBean.java Outdated Show resolved Hide resolved

aureamunoz force-pushed the stork-observability branch 2 times, most recently from 4957b27 to dd7f3c1 Compare September 22, 2023 14:39

cescoffier requested changes Sep 25, 2023

View reviewed changes

aureamunoz force-pushed the stork-observability branch from dd7f3c1 to 531532c Compare September 26, 2023 17:23

aureamunoz requested review from cescoffier and brunobat September 26, 2023 17:24

aureamunoz force-pushed the stork-observability branch 2 times, most recently from 8b20409 to ea04ddb Compare September 26, 2023 17:32

cescoffier requested changes Sep 27, 2023

View reviewed changes

.../src/main/java/io/quarkus/micrometer/runtime/binder/stork/StorkObservationCollectorBean.java Outdated Show resolved Hide resolved

.../src/main/java/io/quarkus/micrometer/runtime/binder/stork/StorkObservationCollectorBean.java Outdated Show resolved Hide resolved

aureamunoz force-pushed the stork-observability branch from 4b96595 to fd12e78 Compare September 27, 2023 15:33

quarkus-bot bot added the area/openapi label Sep 27, 2023

aureamunoz force-pushed the stork-observability branch from fd12e78 to d73f80d Compare September 28, 2023 10:11

aureamunoz requested a review from cescoffier September 28, 2023 10:13

aureamunoz force-pushed the stork-observability branch from d73f80d to 3be8196 Compare September 29, 2023 10:03

cescoffier requested changes Oct 2, 2023

View reviewed changes

aureamunoz force-pushed the stork-observability branch from 3be8196 to 354ee28 Compare October 9, 2023 14:30

quarkus-bot bot added the area/documentation label Oct 9, 2023

quarkus-bot bot added this to To do in Quarkus Documentation Oct 9, 2023

aureamunoz force-pushed the stork-observability branch from 650a481 to 355309a Compare October 11, 2023 15:18

aureamunoz marked this pull request as ready for review October 11, 2023 15:18

aureamunoz requested a review from cescoffier October 11, 2023 15:18

This comment has been minimized.

Sign in to view

cescoffier requested changes Oct 12, 2023

View reviewed changes

Quarkus Documentation automation moved this from To do to Review pending Oct 12, 2023

aureamunoz force-pushed the stork-observability branch from 355309a to ca9e2f7 Compare October 16, 2023 08:39

This comment has been minimized.

Sign in to view

aureamunoz force-pushed the stork-observability branch from ca9e2f7 to fbfd643 Compare October 16, 2023 20:10

This comment has been minimized.

Sign in to view

cescoffier approved these changes Oct 18, 2023

View reviewed changes

Quarkus Documentation automation moved this from Review pending to Reviewer approved Oct 18, 2023

aureamunoz force-pushed the stork-observability branch from fbfd643 to 8760f3b Compare October 18, 2023 09:20

brunobat requested changes Oct 18, 2023

View reviewed changes

docs/src/main/asciidoc/stork-reference.adoc Show resolved Hide resolved

Quarkus Documentation automation moved this from Reviewer approved to Review pending Oct 18, 2023

This comment has been minimized.

Sign in to view

aureamunoz force-pushed the stork-observability branch from 8760f3b to 61d6427 Compare October 19, 2023 11:51

aureamunoz requested a review from brunobat October 19, 2023 11:52

brunobat approved these changes Oct 19, 2023

View reviewed changes

Quarkus Documentation automation moved this from Review pending to Reviewer approved Oct 19, 2023

This comment has been minimized.

Sign in to view

Stork observability integration

ebbcf7c

aureamunoz force-pushed the stork-observability branch from 61d6427 to ebbcf7c Compare October 23, 2023 08:52

cescoffier approved these changes Oct 24, 2023

View reviewed changes

cescoffier merged commit 7f60cf1 into quarkusio:main Oct 24, 2023
46 of 52 checks passed

Quarkus Documentation automation moved this from Reviewer approved to Done Oct 24, 2023

quarkus-bot bot added this to the 3.6 - main milestone Oct 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stork observability #35934

Stork observability #35934

aureamunoz commented Sep 14, 2023

quarkus-bot bot commented Sep 14, 2023

This comment has been minimized.

cescoffier left a comment

aureamunoz commented Oct 16, 2023

This comment has been minimized.

github-actions bot commented Oct 16, 2023 •

edited

This comment has been minimized.

cescoffier left a comment •

edited

gsmet commented Oct 18, 2023

brunobat left a comment

This comment has been minimized.

This comment has been minimized.

quarkus-bot bot commented Oct 23, 2023

Stork observability #35934

Stork observability #35934

Conversation

aureamunoz commented Sep 14, 2023

quarkus-bot bot commented Sep 14, 2023

This comment has been minimized.

cescoffier left a comment

Choose a reason for hiding this comment

aureamunoz commented Oct 16, 2023

This comment has been minimized.

github-actions bot commented Oct 16, 2023 • edited

This comment has been minimized.

cescoffier left a comment • edited

Choose a reason for hiding this comment

gsmet commented Oct 18, 2023

brunobat left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

quarkus-bot bot commented Oct 23, 2023

Failing Jobs - Building ebbcf7c

Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/hibernate-orm/deployment

📦 extensions/oidc-client-graphql/deployment

⚙️ JVM Tests - JDK 17 #

📦 extensions/oidc-client-graphql/deployment

⚙️ JVM Tests - JDK 17 Windows #

📦 extensions/vertx-http/deployment

⚙️ Maven Tests - JDK 11 Windows #

📦 integration-tests/maven

⚙️ Native Tests - Messaging1 #

📦 integration-tests/kafka-oauth-keycloak

github-actions bot commented Oct 16, 2023 •

edited

cescoffier left a comment •

edited

Failing Jobs - Building `ebbcf7c`