Fix tracing protocol configuration to only allow grpc #36166
Conversation
|
/cc @brunobat (opentelemetry), @radcortez (opentelemetry) |
This comment has been minimized.
This comment has been minimized.
|
@brunobat this makes sense to me given the exception we throw but I would prefer if you had a look. |
...metry/runtime/src/main/java/io/quarkus/opentelemetry/runtime/exporter/otlp/OtlpRecorder.java
Show resolved
Hide resolved
|
@siewp are you going to continue with the PR? |
Yes, sorry. Had no time until today. I will continue with it later. |
|
@siewp can you please squash the into a single commit? |
siewp
force-pushed
the
fix-otel-traces-protocol-config
branch
from
fa6944c
to
8d3cde5
Compare
Adjust exception message for unsupported tracing exporter protocols Add test for unsupported otlp exporter protocol config
siewp
force-pushed
the
fix-otel-traces-protocol-config
branch
from
8d3cde5
to
7b5f270
Compare
|
@brunobat Done! |
|
@gsmet Is there anything else that needs to be done to merge this PR? |
|
@brunobat is the equivalent change present in main? Is it still good to merge in 3.2? Thanks! |
|
The code in main has diverged after v3.3 (removed backport triage for 3.5), however this PR still makes sense to v3.2 @aloubyansky. CC @gsmet |
|
Pushing things to 3.2 only is not very usual, that's why this somehow felt through the cracks. @aloubyansky @rsvoboda this one would probably require you having a look. |
|
I added the |
|
We had triage with Alexey, that's why he added the comment here. There wasn't any PR to main from @siewp This was found when looking into PRs created directly against 3.2 ( |
|
yes, main had diverged significantly at that point, not needing this pr. This is because we now have totally different exporters. |
Fixes #36084