Update to the JDBCStore section of the Transaction guide

[MichalMaler]

Adding:

• Some information mentioned by @maxandersen in the Transaction gdoc draft.
• Link to a complete list of Narayana configuration options.
• Additional context info and proper terminology.
• Removing metadata :sumary: from the top of the file since this is automatically taken from the first sentence that acts as guide intro.
• Adding metadata diataxis-template: reference
• Tiny style tweaks.
• Proper headings capitalization

@zhfeng @mmusgrov , please have a look and provide an SME review when time and mood.
Thank you.

[github-actions]

🙈 The PR is closed and the preview is expired.

[MichalMaler]

Removing this bit:

Storing transaction logs into a database is slower, creates bigger overhead, and requires higher maintenance.
Use this approach when prioritizing consistency over throughput.

[MichalMaler]

@mmusgrov @jmfinelli
Thank you for your feedback. I applied it to my best extend. Pleas, have a look on it now:
https://github.com/quarkusio/quarkus/blob/a5d654f859ae23f7524e2f95494d274178a5c7b2/docs/src/main/asciidoc/transaction.adoc#configure-storing-of-quarkus-transaction-logs-in-a-database

If you have any additional suggestions, please do one of the following so that we are not creating the comment wall of text again:

1. Apply the direct suggestion which I can accept and commit
   or
2. Have a look on the entire text in this doc and lets tune it to your ideal shape there. https://docs.google.com/document/d/1jLNPsgC57V3S1FjWpbWJJcRB13-MSi_WmVneABOitMc/edit

[mmusgrov]

@mmusgrov @jmfinelli Thank you for your feedback. I applied it to my best extend. Pleas, have a look on it now: https://github.com/quarkusio/quarkus/blob/a5d654f859ae23f7524e2f95494d274178a5c7b2/docs/src/main/asciidoc/transaction.adoc#configure-storing-of-quarkus-transaction-logs-in-a-database

If you have any additional suggestions, please do one of the following so that we are not creating the comment wall of text again:

1. Apply the direct suggestion which I can accept and commit

That could be a lot of work for one of us. @jmfinelli , should one of us rewrite the quarkus transaction guide, unfortunately the transactions team are under resourced and we have a backlog of work.

or
2. Have a look on the entire text in this doc and lets tune it to your ideal shape there. https://docs.google.com/document/d/1jLNPsgC57V3S1FjWpbWJJcRB13-MSi_WmVneABOitMc/edit

I don't really understand that document, how does it relate to this PR?

[MichalMaler]

@mmusgrov @jmfinelli Thank you for your feedback. I applied it to my best extend. Pleas, have a look on it now: https://github.com/quarkusio/quarkus/blob/a5d654f859ae23f7524e2f95494d274178a5c7b2/docs/src/main/asciidoc/transaction.adoc#configure-storing-of-quarkus-transaction-logs-in-a-database
If you have any additional suggestions, please do one of the following so that we are not creating the comment wall of text again:

1. Apply the direct suggestion which I can accept and commit

That could be a lot of work for one of us. @jmfinelli , should one of us rewrite the quarkus transaction guide, unfortunately the transactions team are under resourced and we have a backlog of work.

or
2. Have a look on the entire text in this doc and lets tune it to your ideal shape there. https://docs.google.com/document/d/1jLNPsgC57V3S1FjWpbWJJcRB13-MSi_WmVneABOitMc/edit

I don't really understand that document, how does it relate to this PR?

The content of this PR can be find on the page 1 and 2 of the attached file.

I will go trough your suggestion one more time and rewrite start of this chapter, even if it was not target of this PR.
Then, I would kindly asked a Transaction guide SME for merge or close.
Any member of the Narayana team then can open a new PR and add additional details.

[MichalMaler]

@mmusgrov @jmfinelli
Can you let me know if this Solved issue was already implemented to Quarkus?
https://issues.redhat.com/browse/AG-209

If so, I can remove this part from the guide.

[NOTE]
====
To work around the current known issue of link:https://issues.redhat.com/browse/AG-209[Agroal having a different view on running transaction checks], set the datasource transaction type for the datasource responsible for writing the transaction logs to `disabled`:

----
quarkus.datasource.TX_LOG.jdbc.transactions=disabled
----

This example uses TX_LOG as the datasource name.
====

[zhfeng]

LGTM

[yrodiere]

Here's a review as you requested, @MichalMaler ... Not sure this helps much, sorry :/

[yrodiere]

Looks good to me, thanks.

@jmfinelli Can you confirm your concerns were addressed? Thanks.

[jmfinelli]

Looks good to me, thanks.

@jmfinelli Can you confirm your concerns were addressed? Thanks.

Sorry @yrodiere. I am trying review this PR as soon as possible but, as the git history is re-written all the time, is not easy.

[jmfinelli]

Thanks @MichalMaler. Just one last modification 👍

[jmfinelli]

Thanks @MichalMaler :-)