New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for AddingSpanAttributes #36271
Conversation
/cc @radcortez (opentelemetry) |
cc @ennishol |
🙈 The PR is closed and the preview is expired. |
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
Just curious but wouldn't it be better to make
an error instead? |
It could @geoand , but the OTel instrumentation tests assume this priority and I wanted to keep it consistent. |
Gotcha, thanks |
Resolves #36138
Annotating a method in any CDI aware bean with the
io.opentelemetry.instrumentation.annotations.AddingSpanAttributes
will not create a new span but will add annotated method parameters to attributes in the current span.If a method is annotated by mistake with
@AddingSpanAttributes
and@WithSpan
annotations, the@WithSpan
annotation will take precedence.