Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for AddingSpanAttributes #36271

Merged
merged 1 commit into from Oct 5, 2023
Merged

Conversation

brunobat
Copy link
Contributor

@brunobat brunobat commented Oct 3, 2023

Resolves #36138

Annotating a method in any CDI aware bean with the io.opentelemetry.instrumentation.annotations.AddingSpanAttributes will not create a new span but will add annotated method parameters to attributes in the current span.

If a method is annotated by mistake with @AddingSpanAttributes and @WithSpan annotations, the @WithSpan annotation will take precedence.

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 3, 2023

/cc @radcortez (opentelemetry)

@quarkus-bot quarkus-bot bot added this to To do in Quarkus Documentation Oct 3, 2023
@brunobat
Copy link
Contributor Author

brunobat commented Oct 3, 2023

cc @ennishol

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

🙈 The PR is closed and the preview is expired.

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 3, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@brunobat brunobat requested review from alesj and geoand October 4, 2023 14:57
@geoand
Copy link
Contributor

geoand commented Oct 4, 2023

Just curious but wouldn't it be better to make

If a method is annotated by mistake with @AddingSpanAttributes and @WithSpan annotations, the @WithSpan annotation will take precedence.

an error instead?

@geoand
Copy link
Contributor

geoand commented Oct 4, 2023

Gotcha, thanks

Quarkus Documentation automation moved this from To do to Reviewer approved Oct 4, 2023
@gsmet gsmet merged commit b9b923c into quarkusio:main Oct 5, 2023
30 checks passed
Quarkus Documentation automation moved this from Reviewer approved to Done Oct 5, 2023
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Oct 5, 2023
@quarkus-bot quarkus-bot bot added this to the 3.5 - main milestone Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Add support for @AddingSpanAttributes
5 participants