Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify REST Clients extension names #36447

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Oct 12, 2023

This is a proposal, feel free to dismiss.

The idea is to have:

  • RESTEasy Classic's REST Client
  • RESTEasy Reactive's REST Client

so that what you need to use is extra clear.

(This PR is part of various things noted when I added the :topics: to the guides)

BTW, I didn't do it there but I also think we should move the REST Client Config extension, which is common to both RESTEasy Classic and RESTEasy Reactive IIUC, outside of the RESTEasy Classic folder. Let me know what you think, I can do it in a follow-up PR.

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no strong opinion either way, so let's do it 🙂

@geoand
Copy link
Contributor

geoand commented Oct 12, 2023

BTW, I didn't do it there but I also think we should move the REST Client Config extension, which is common to both RESTEasy Classic and RESTEasy Reactive IIUC, outside of the RESTEasy Classic folder. Let me know what you think, I can do it in a follow-up PR.

Definitely +1

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 12, 2023

Failing Jobs - Building aa26b69

Status Name Step Failures Logs Raw logs Build scan
JVM Tests - JDK 11 Build Failures Logs Raw logs
JVM Tests - JDK 17 Build Failures Logs Raw logs
JVM Tests - JDK 20 Build Failures Logs Raw logs
Native Tests - Windows - RESTEasy Jackson Setup GraalVM ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/oidc-client-graphql/deployment 

📦 extensions/oidc-client-graphql/deployment

io.quarkus.oidc.client.graphql.GraphQLClientUsingOidcClientTest.typesafeClientWithDefault - More details - Source on GitHub

io.quarkus.dev.appstate.ApplicationStartException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.dev.appstate.ApplicationStateNotification.waitForApplicationStart(ApplicationStateNotification.java:58)
	at io.quarkus.runner.bootstrap.StartupActionImpl.runMainClass(StartupActionImpl.java:132)

io.quarkus.oidc.client.graphql.GraphQLClientUsingOidcClientTest.typesafeClientAnnotation - More details - Source on GitHub

io.quarkus.dev.appstate.ApplicationStartException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.dev.appstate.ApplicationStateNotification.waitForApplicationStart(ApplicationStateNotification.java:58)
	at io.quarkus.runner.bootstrap.StartupActionImpl.runMainClass(StartupActionImpl.java:132)

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/oidc-client-graphql/deployment 

📦 extensions/oidc-client-graphql/deployment

io.quarkus.oidc.client.graphql.GraphQLClientUsingOidcClientTest.typesafeClientWithDefault - More details - Source on GitHub

io.quarkus.dev.appstate.ApplicationStartException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.dev.appstate.ApplicationStateNotification.waitForApplicationStart(ApplicationStateNotification.java:58)
	at io.quarkus.runner.bootstrap.StartupActionImpl.runMainClass(StartupActionImpl.java:132)

⚙️ JVM Tests - JDK 20 #

- Failing: extensions/oidc-client-graphql/deployment 

📦 extensions/oidc-client-graphql/deployment

io.quarkus.oidc.client.graphql.GraphQLClientUsingOidcClientTest.typesafeClientAnnotation - More details - Source on GitHub

io.quarkus.dev.appstate.ApplicationStartException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.dev.appstate.ApplicationStateNotification.waitForApplicationStart(ApplicationStateNotification.java:58)
	at io.quarkus.runner.bootstrap.StartupActionImpl.runMainClass(StartupActionImpl.java:132)

@gsmet
Copy link
Member Author

gsmet commented Oct 13, 2023

@jmartisk this GraphQL test looks unstable. I think there might be a race condition in what you did.

io.quarkus.dev.appstate.ApplicationStartException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.dev.appstate.ApplicationStateNotification.waitForApplicationStart(ApplicationStateNotification.java:58)
	at io.quarkus.runner.bootstrap.StartupActionImpl.runMainClass(StartupActionImpl.java:132)
	at io.quarkus.deployment.dev.IsolatedDevModeMain.firstStart(IsolatedDevModeMain.java:115)
	at io.quarkus.deployment.dev.IsolatedDevModeMain.accept(IsolatedDevModeMain.java:438)
	at io.quarkus.deployment.dev.IsolatedDevModeMain.accept(IsolatedDevModeMain.java:56)
	at io.quarkus.bootstrap.app.CuratedApplication.runInCl(CuratedApplication.java:138)
	at io.quarkus.bootstrap.app.CuratedApplication.runInAugmentClassLoader(CuratedApplication.java:93)
	at io.quarkus.deployment.dev.DevModeMain.start(DevModeMain.java:131)
	at io.quarkus.test.QuarkusDevModeTest.beforeEach(QuarkusDevModeTest.java:302)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
Caused by: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source)
	at io.quarkus.runtime.Application.start(Application.java:101)
	at io.quarkus.runtime.ApplicationLifecycleManager.run(ApplicationLifecycleManager.java:111)
	at io.quarkus.runtime.Quarkus.run(Quarkus.java:71)
	at io.quarkus.runtime.Quarkus.run(Quarkus.java:44)
	at io.quarkus.runtime.Quarkus.run(Quarkus.java:124)
	at io.quarkus.runner.GeneratedMain.main(Unknown Source)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at io.quarkus.runner.bootstrap.StartupActionImpl$1.run(StartupActionImpl.java:113)
	at java.base/java.lang.Thread.run(Thread.java:829)
Caused by: java.lang.NullPointerException
	at io.quarkus.oidc.client.graphql.runtime.OidcGraphQLClientIntegrationRecorder.lambda$enhanceGraphQLClientConfigurationWithOidc$0(OidcGraphQLClientIntegrationRecorder.java:25)
	at java.base/java.util.HashMap.forEach(HashMap.java:1337)
	at io.quarkus.oidc.client.graphql.runtime.OidcGraphQLClientIntegrationRecorder.enhanceGraphQLClientConfigurationWithOidc(OidcGraphQLClientIntegrationRecorder.java:19)
	at io.quarkus.deployment.steps.OidcGraphQLClientIntegrationProcessor$initialize1724027614.deploy_0(Unknown Source)
	at io.quarkus.deployment.steps.OidcGraphQLClientIntegrationProcessor$initialize1724027614.deploy(Unknown Source)
	... 10 more

@gsmet gsmet merged commit fcf16c1 into quarkusio:main Oct 13, 2023
47 of 51 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.6 - main milestone Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants