Get rid of {doc-guides} attribute in documentation #36477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has been mistakenly used in the newest guide that was added as shown in quarkusio#36474 where we had: - one invalid link because of a missing / - one invalid link because an incorrect attribute was used We see it's risky and it has no more value since we introduced the downstream archive as we automatically transform the links there to point to either a local one or one that is upstream. IIRC, Michelle already removed some and I don't think it's recommended nowadays. Note: I haven't handled the getting-started-devservices.adoc here on purpose as Leonor is working on it. Will handle it if needed once Leonor's PR is in.
quarkus-bot
bot
added
area/docstyle
|
🙈 The PR is closed and the preview is expired. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been mistakenly used in the newest guide that was added as shown in #36474 where we had:
We see it's risky and it has no more value since
we introduced the downstream archive as we automatically transform the links there to point to either a local one or one that is upstream.
IIRC, Michelle already removed some and I don't think it's recommended nowadays.
Note: I haven't handled the getting-started-devservices.adoc here on purpose as Leonor is working on it. Will handle it if needed once Leonor's PR is in.