Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS content review #36667

Merged
merged 1 commit into from
Oct 24, 2023
Merged

CORS content review #36667

merged 1 commit into from
Oct 24, 2023

Conversation

MichalMaler
Copy link
Contributor

@MichalMaler MichalMaler commented Oct 24, 2023

Creating this PR to separate pure CORS content from the already opened PR that mix the same changes as this PR with some other fixes that got into my cross hair.

This is the docs team follow-up of the @sberyozkin 's PR https://github.com/quarkusio/quarkus/pull/36541/files

This PR already contains SME review of @sberyozkin and @jmartisk .

Signed-off-by: Michal Maléř <mmaler@redhat.com>
Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MichalMaler, @jmartisk, sorry for the hassle with having it opened in a dedicated PR, but hope you'll find it easier to deal with various backport requirements later

Quarkus Documentation automation moved this from To do to Reviewer approved Oct 24, 2023
@MichalMaler
Copy link
Contributor Author

Thanks @MichalMaler, @jmartisk, sorry for the hassle with having it opened in a dedicated PR, but hope you'll find it easier to deal with various backport requirements later

Cool. No worries. Please attach the needed labels and feel free to merge :)

@MichalMaler
Copy link
Contributor Author

@rsvoboda Hello Rostislav! Do we want this PR to be backported to 3.2?
Cheers.

@MichalMaler MichalMaler added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 24, 2023
@sberyozkin sberyozkin merged commit e68c822 into quarkusio:main Oct 24, 2023
5 checks passed
Quarkus Documentation automation moved this from Reviewer approved to Done Oct 24, 2023
@quarkus-bot quarkus-bot bot added this to the 3.6 - main milestone Oct 24, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 24, 2023
@github-actions
Copy link

github-actions bot commented Oct 24, 2023

🎊 PR Preview ee1d5a3 has been successfully built and deployed to https://quarkus-pr-main-36667-preview.surge.sh/version/main/guides/

@MichalMaler MichalMaler deleted the Pure-CORS-review branch October 24, 2023 19:31
@rsvoboda
Copy link
Member

rsvoboda commented Oct 25, 2023

PR looks good to me, thanks @MichalMaler

@sberyozkin there are quite a few changes going on around security guides, they should be probably marked for backport to 3.2 because security guides are planned for downstream. WDYT?

Or we can process what's available in 3.2 branch and pick the current (and future) changes in the next feature release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants