Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable MySQL OIDC DB token manager test due to limited Github CI resources #36695

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

sberyozkin
Copy link
Member

This test unfortunately keeps failing, but we still have a few other DB tests in deployment plus an Oracle DB integration test

@gsmet
Copy link
Member

gsmet commented Oct 25, 2023

TBH, I'm not sure it's really necessary to test this feature with all the supported databases. Testing only with PostgreSQL would have my preference.

@michalvavrik
Copy link
Contributor

michalvavrik commented Oct 25, 2023

There is nothing wrong with these tests. They are there because you io.vertx:vertx-sql-client only provides with common classes and API, actual implementation may differs (e.g. in param placeholders) and when there will be any changes (like Vert.x reactive sql client bump or in the extension itself), we need to re-run them to know stuff works.

Actual failure:

2023-10-24T18:20:18.3456000Z 2023-10-24 18:20:18,334 INFO  [tc.qua.io/.0.4] (build-8) Container quay.io/keycloak/keycloak:22.0.4 started in PT27.316709626S
2023-10-24T18:20:22.3657483Z 2023-10-24 18:20:22,361 ERROR [io.qua.oid.dep.dev.key.KeycloakDevServicesProcessor] (build-8) Admin token can not be acquired: null [Error Occurred After Shutdown]
2023-10-24T18:20:22.4658950Z 2023-10-24 18:20:22,395 ERROR [io.qua.oid.dep.dev.key.KeycloakDevServicesProcessor] (build-8) Realm quarkus can not be created 401 - Unauthorized  [Error Occurred After Shutdown]

I read as: Keycloak Dev Services start Keycloak and than it can't be used and there is no failure, app keeps going on.

With that said, I understand resources are tight and you know best what is possible to run and what is not. The fact is it keeps failing in CI. And I don't know how to fix it.

@michalvavrik michalvavrik requested review from gsmet and removed request for michalvavrik October 25, 2023 16:10
@sberyozkin
Copy link
Member Author

sberyozkin commented Oct 25, 2023

Hey Michal, yeah, your tests are of good quality, but indeed, we don't need to be concerned about the portability of various reactive DB clients with respect to this feature, it is not of major concern for this extension as long as the concept is tested with a mainstream DB like Postgresql.

And we have this feature tested with Oracle in Native

@sberyozkin
Copy link
Member Author

sberyozkin commented Oct 25, 2023

May be DevService which is being closed is holding on to some resources for too long, but I'd not be worried about it when testing this extension :-)

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 25, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@sberyozkin
Copy link
Member Author

sberyozkin commented Oct 26, 2023

@gsmet This one can go in now too I believe - will def save some resources too

@sberyozkin
Copy link
Member Author

sberyozkin commented Oct 26, 2023

@gastaldi Can you please consider approving this one as @gsmet may not be available ? This is a test added my Michal, and he approved disabling it to relieve some pressure on CI, and it is in line with what @gsmet commented above

@gastaldi gastaldi merged commit 55bd9e9 into quarkusio:main Oct 26, 2023
19 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.6 - main milestone Oct 26, 2023
@sberyozkin sberyozkin deleted the disable_oidc_db_mysql_test branch October 26, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants