Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka Streams Dev UI migration to v2 #36706

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

dcotfr
Copy link
Contributor

@dcotfr dcotfr commented Oct 26, 2023

@phillip-kruger Resend new clean PR after accidentaly closed @#36650

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/kafka-streams labels Oct 26, 2023
@phillip-kruger
Copy link
Member

@dcotfr Thanks ! I'll send you the locking info soon

@dcotfr dcotfr marked this pull request as ready for review October 26, 2023 18:37
@phillip-kruger
Copy link
Member

@dcotfr - please add all these to the build-parent so that we can lock the dependencies:

<dependency>
    <groupId>org.mvnpm.at.hpcc-js</groupId>
    <artifactId>wasm</artifactId>
    <version>2.14.1</version>
    <scope>runtime</scope>
</dependency>

<dependency>
	<groupId>org.mvnpm</groupId>
	<artifactId>yargs</artifactId>
	<version>17.7.2</version>
	<scope>runtime</scope>
</dependency>

<dependency>
	<groupId>org.mvnpm</groupId>
	<artifactId>cliui</artifactId>
	<version>8.0.1</version>
	<scope>runtime</scope>
</dependency>

<dependency>
	<groupId>org.mvnpm</groupId>
	<artifactId>escalade</artifactId>
	<version>3.1.1</version>
	<scope>runtime</scope>
</dependency>

<dependency>
	<groupId>org.mvnpm</groupId>
	<artifactId>get-caller-file</artifactId>
	<version>2.0.5</version>
	<scope>runtime</scope>
</dependency>

<dependency>
	<groupId>org.mvnpm</groupId>
	<artifactId>require-directory</artifactId>
	<version>2.1.1</version>
	<scope>runtime</scope>
</dependency>

<dependency>
	<groupId>org.mvnpm</groupId>
	<artifactId>string-width</artifactId>
	<version>4.2.3</version>
	<scope>runtime</scope>
</dependency>

<dependency>
	<groupId>org.mvnpm</groupId>
	<artifactId>y18n</artifactId>
	<version>5.0.8</version>
	<scope>runtime</scope>
</dependency>

<dependency>
	<groupId>org.mvnpm</groupId>
	<artifactId>yargs-parser</artifactId>
	<version>21.1.1</version>
	<scope>runtime</scope>
</dependency>


<dependency>
	<groupId>org.mvnpm</groupId>
	<artifactId>strip-ansi</artifactId>
	<version>6.0.1</version>
	<scope>runtime</scope>
</dependency>

<dependency>
	<groupId>org.mvnpm</groupId>
	<artifactId>wrap-ansi</artifactId>
	<version>7.0.0</version>
	<scope>runtime</scope>
</dependency>

<dependency>
	<groupId>org.mvnpm</groupId>
	<artifactId>emoji-regex</artifactId>
	<version>8.0.0</version>
	<scope>runtime</scope>
</dependency>

<dependency>
	<groupId>org.mvnpm</groupId>
	<artifactId>is-fullwidth-code-point</artifactId>
	<version>3.0.0</version>
	<scope>runtime</scope>
</dependency>

<dependency>
	<groupId>org.mvnpm</groupId>
	<artifactId>ansi-regex</artifactId>
	<version>5.0.1</version>
	<scope>runtime</scope>
</dependency>

<dependency>
	<groupId>org.mvnpm</groupId>
	<artifactId>ansi-styles</artifactId>
	<version>4.3.0</version>
	<scope>runtime</scope>
</dependency>

<dependency>
	<groupId>org.mvnpm</groupId>
	<artifactId>color-convert</artifactId>
	<version>2.0.1</version>
	<scope>runtime</scope>
</dependency>

<dependency>
	<groupId>org.mvnpm</groupId>
	<artifactId>color-name</artifactId>
	<version>1.1.4</version>
	<scope>runtime</scope>
</dependency>

Let me know. Thanks

@quarkus-bot

This comment has been minimized.

@phillip-kruger phillip-kruger added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 29, 2023
@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@phillip-kruger
Copy link
Member

@dcotfr please can you rebase on main again and force push, that hopefully will give us a green CI

@quarkus-bot

This comment has been minimized.

@quarkus-bot
Copy link

quarkus-bot bot commented Nov 2, 2023

Failing Jobs - Building 8f59da1

Status Name Step Failures Logs Raw logs Build scan
Devtools Tests - JDK 11 Build Failures Logs Raw logs
Devtools Tests - JDK 11 Windows Build Failures Logs Raw logs
Devtools Tests - JDK 17 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 21

Full information is available in the Build summary check run.

Failures

⚙️ Devtools Tests - JDK 11 #

- Failing: integration-tests/devtools 

📦 integration-tests/devtools

io.quarkus.devtools.codestarts.quarkus.AmazonLambdaCodestartTest.testContent line 23 - More details - Source on GitHub

java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): AmazonLambdaCodestartTest/testContent/src_test_java_ilove_quark_us_lambda_LambdaHandlerTest.java] 
Path:

io.quarkus.devtools.codestarts.quarkus.FunqyAmazonLambdaCodestartTest.testContent line 23 - More details - Source on GitHub

java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): FunqyAmazonLambdaCodestartTest/testContent/src_test_java_ilove_quark_us_funqy_FunqyTest.java] 
Path:

io.quarkus.devtools.codestarts.quarkus.FunqyGoogleCloudFunctionsCodestartTest.testContent line 23 - More details - Source on GitHub

java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): FunqyGoogleCloudFunctionsCodestartTest/testContent/src_test_java_ilove_quark_us_funqygooglecloudfunctions_GreetingFunctionsCloudEventsTest.java] 
Path:

io.quarkus.devtools.codestarts.quarkus.FunqyHttpCodestartTest.testContent line 22 - More details - Source on GitHub

java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): FunqyHttpCodestartTest/testContent/src_test_java_ilove_quark_us_MyFunctionsTest.java] 
Path:

io.quarkus.devtools.codestarts.quarkus.FunqyKnativeEventsCodestartTest.testContent line 23 - More details - Source on GitHub

java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): FunqyKnativeEventsCodestartTest/testContent/src_test_java_ilove_quark_us_funqy_cloudevent_FunqyTest.java] 
Path:

io.quarkus.devtools.codestarts.quarkus.GoogleCloudFunctionsCodestartTest.testContent line 24 - More details - Source on GitHub

java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): GoogleCloudFunctionsCodestartTest/testContent/src_test_java_ilove_quark_us_googlecloudfunctions_HelloWorldCloudEventsFunctionTest.java] 
Path:

io.quarkus.devtools.codestarts.quarkus.GrpcCodestartTest.testContent line 23 - More details - Source on GitHub

java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): GrpcCodestartTest/testContent/src_test_java_ilove_quark_us_HelloGrpcServiceTest.java] 
Path:

⚙️ Devtools Tests - JDK 11 Windows #

- Failing: integration-tests/devtools 

📦 integration-tests/devtools

io.quarkus.devtools.codestarts.quarkus.AmazonLambdaCodestartTest.testContent line 23 - More details - Source on GitHub

java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): AmazonLambdaCodestartTest/testContent/src_test_java_ilove_quark_us_lambda_LambdaHandlerTest.java] 
Path:

io.quarkus.devtools.codestarts.quarkus.FunqyAmazonLambdaCodestartTest.testContent line 23 - More details - Source on GitHub

java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): FunqyAmazonLambdaCodestartTest/testContent/src_test_java_ilove_quark_us_funqy_FunqyTest.java] 
Path:

io.quarkus.devtools.codestarts.quarkus.FunqyGoogleCloudFunctionsCodestartTest.testContent line 23 - More details - Source on GitHub

java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): FunqyGoogleCloudFunctionsCodestartTest/testContent/src_test_java_ilove_quark_us_funqygooglecloudfunctions_GreetingFunctionsCloudEventsTest.java] 
Path:

io.quarkus.devtools.codestarts.quarkus.FunqyHttpCodestartTest.testContent line 22 - More details - Source on GitHub

java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): FunqyHttpCodestartTest/testContent/src_test_java_ilove_quark_us_MyFunctionsTest.java] 
Path:

io.quarkus.devtools.codestarts.quarkus.FunqyKnativeEventsCodestartTest.testContent line 23 - More details - Source on GitHub

java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): FunqyKnativeEventsCodestartTest/testContent/src_test_java_ilove_quark_us_funqy_cloudevent_FunqyTest.java] 
Path:

io.quarkus.devtools.codestarts.quarkus.GoogleCloudFunctionsCodestartTest.testContent line 24 - More details - Source on GitHub

java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): GoogleCloudFunctionsCodestartTest/testContent/src_test_java_ilove_quark_us_googlecloudfunctions_HelloWorldCloudEventsFunctionTest.java] 
Path:

io.quarkus.devtools.codestarts.quarkus.GrpcCodestartTest.testContent line 23 - More details - Source on GitHub

java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): GrpcCodestartTest/testContent/src_test_java_ilove_quark_us_HelloGrpcServiceTest.java] 
Path:

⚙️ Devtools Tests - JDK 17 #

- Failing: integration-tests/devtools 

📦 integration-tests/devtools

io.quarkus.devtools.codestarts.quarkus.AmazonLambdaCodestartTest.testContent line 23 - More details - Source on GitHub

java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): AmazonLambdaCodestartTest/testContent/src_test_java_ilove_quark_us_lambda_LambdaHandlerTest.java] 
Path:

io.quarkus.devtools.codestarts.quarkus.FunqyAmazonLambdaCodestartTest.testContent line 23 - More details - Source on GitHub

java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): FunqyAmazonLambdaCodestartTest/testContent/src_test_java_ilove_quark_us_funqy_FunqyTest.java] 
Path:

io.quarkus.devtools.codestarts.quarkus.FunqyGoogleCloudFunctionsCodestartTest.testContent line 23 - More details - Source on GitHub

java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): FunqyGoogleCloudFunctionsCodestartTest/testContent/src_test_java_ilove_quark_us_funqygooglecloudfunctions_GreetingFunctionsCloudEventsTest.java] 
Path:

io.quarkus.devtools.codestarts.quarkus.FunqyHttpCodestartTest.testContent line 22 - More details - Source on GitHub

java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): FunqyHttpCodestartTest/testContent/src_test_java_ilove_quark_us_MyFunctionsTest.java] 
Path:

io.quarkus.devtools.codestarts.quarkus.FunqyKnativeEventsCodestartTest.testContent line 23 - More details - Source on GitHub

java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): FunqyKnativeEventsCodestartTest/testContent/src_test_java_ilove_quark_us_funqy_cloudevent_FunqyTest.java] 
Path:

io.quarkus.devtools.codestarts.quarkus.GoogleCloudFunctionsCodestartTest.testContent line 24 - More details - Source on GitHub

java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): GoogleCloudFunctionsCodestartTest/testContent/src_test_java_ilove_quark_us_googlecloudfunctions_HelloWorldCloudEventsFunctionTest.java] 
Path:

io.quarkus.devtools.codestarts.quarkus.GrpcCodestartTest.testContent line 23 - More details - Source on GitHub

java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): GrpcCodestartTest/testContent/src_test_java_ilove_quark_us_HelloGrpcServiceTest.java] 
Path:

⚙️ JVM Tests - JDK 17 Windows #

- Failing: integration-tests/smallrye-context-propagation 

📦 integration-tests/smallrye-context-propagation

io.quarkus.context.test.SimpleContextPropagationTest.testArcTCContextPropagationDisabled line 92 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <2> but was: <3>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

@phillip-kruger phillip-kruger merged commit ff1d55c into quarkusio:main Nov 2, 2023
47 of 51 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.6 - main milestone Nov 2, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/kafka-streams
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants