Add a description to the Stork extension metadata #36718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aureamunoz
approved these changes
Oct 26, 2023
gsmet
reviewed
Oct 26, 2023
There was a problem hiding this comment.
IIRC, the convention is to add the description in the runtime pom: https://github.com/quarkusio/quarkus/blob/main/extensions/smallrye-stork/runtime/pom.xml#L14
This comment has been minimized.
This comment has been minimized.
cescoffier
force-pushed
the
stork-description
branch
from
1f5b9df
to
1e918f1
Compare
|
@gsmet fixed, I moved the description in the pom.xml file. |
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
geoand
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.