Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiny Vale tweaks for Datasource and Logging guide #36837

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

MichalMaler
Copy link
Contributor

These are some tiny cosmetics that support the great effort of @michelle-purcell who incorporates all other writer's feedback on Vale behavior and its follow-up improvisation.

docs/src/main/asciidoc/datasource.adoc Outdated Show resolved Hide resolved
Quarkus Documentation automation moved this from To do to Review pending Nov 2, 2023
@Ladicek
Copy link
Contributor

Ladicek commented Nov 2, 2023

LGTM, just one comment/question.

Copy link

github-actions bot commented Nov 2, 2023

🎊 PR Preview 389a663 has been successfully built and deployed to https://quarkus-pr-main-36837-preview.surge.sh/version/main/guides/

Signed-off-by: Michal Maléř <mmaler@redhat.com>
@MichalMaler
Copy link
Contributor Author

THX @Ladicek n @jmartisk .
Applied your suggestions.
Cheers!

@yrodiere yrodiere added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 2, 2023
Quarkus Documentation automation moved this from Review pending to Reviewer approved Nov 2, 2023
@jmartisk jmartisk merged commit 2fe9d6e into quarkusio:main Nov 2, 2023
5 checks passed
Quarkus Documentation automation moved this from Reviewer approved to Done Nov 2, 2023
@quarkus-bot quarkus-bot bot added this to the 3.6 - main milestone Nov 2, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 2, 2023
Copy link
Contributor

@rolfedh rolfedh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichalMaler MichalMaler deleted the Tiny-Vale-tweaks branch November 2, 2023 15:54
@aloubyansky aloubyansky modified the milestones: 3.6 - main, 3.2.8.Final Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docstyle issues related for manual docstyle review area/documentation
Development

Successfully merging this pull request may close these issues.

None yet

6 participants