Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds download topology as PNG file #36989

Merged
merged 1 commit into from
Nov 11, 2023

Conversation

dcotfr
Copy link
Contributor

@dcotfr dcotfr commented Nov 9, 2023

Proposal to add a button to download the topology schema as a PNG file, in Kafka Streams DevUI, to ease documentation of projects.

image

By default, file is named Topology-application.name-timestamp.png

Tested OK under Edge 119.0.2151.44 (Windows), Firefox 119.0.1 (Windows) and Chrome 119.0.6045.124 (Windows).

@dcotfr dcotfr marked this pull request as ready for review November 9, 2023 22:07
@gsmet
Copy link
Member

gsmet commented Nov 10, 2023

Cool idea, thanks, I will let @phillip-kruger review it.

@quarkus-bot

This comment has been minimized.

@quarkus-bot
Copy link

quarkus-bot bot commented Nov 10, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Copy link
Member

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@phillip-kruger phillip-kruger merged commit de23b9d into quarkusio:main Nov 11, 2023
19 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.6 - main milestone Nov 11, 2023
@dcotfr dcotfr deleted the AddsPngTopologyDownload branch November 14, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants