Provide the ability to define extension Java version on creation #37098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/cli
gsmet
force-pushed
the
extension-java-version
branch
from
53a7e5f
to
015d88d
Compare
This comment has been minimized.
This comment has been minimized.
Also fixes some regressions in the release.yml workflow.
Also use the -parent artifact as there's a good chance it won't be changed in the case of a multimodule extension (see langchain4j for instance).
gsmet
force-pushed
the
extension-java-version
branch
from
015d88d
to
61d059f
Compare
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes a few things in extension creation in passing (especially a regression in the release.yml workflow).
@geoand it could have been useful for you for langchain4j