Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rendering of documentation tooltip when enum description contains paragraphs #37202

Merged
merged 1 commit into from Nov 24, 2023
Merged

Fix rendering of documentation tooltip when enum description contains paragraphs #37202

merged 1 commit into from Nov 24, 2023

Conversation

michalvavrik
Copy link
Contributor

@michalvavrik michalvavrik commented Nov 18, 2023 •
edited

fixes: #36401
supersedes: #36769

@quarkus-bot quarkus-bot bot added area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins labels Nov 18, 2023
@michalvavrik michalvavrik force-pushed the feature/fix-tooltip-renderig-of-desc-with-paragraphs branch from 6b9cd4b to 434173a Compare November 18, 2023 18:15
@michalvavrik michalvavrik mentioned this pull request Nov 18, 2023
Closed
@quarkus-bot

This comment has been minimized.

Sign in to view
gsmet
gsmet reviewed Nov 19, 2023
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for having a look at that, I added a comment inline.

...rocessor/src/main/java/io/quarkus/annotation/processor/generate_doc/ConfigDocItemFinder.java Outdated Show resolved Hide resolved
@michalvavrik michalvavrik force-pushed the feature/fix-tooltip-renderig-of-desc-with-paragraphs branch from 434173a to 8a099af Compare November 20, 2023 09:14
@michalvavrik michalvavrik force-pushed the feature/fix-tooltip-renderig-of-desc-with-paragraphs branch from 8a099af to 151ad84 Compare November 20, 2023 09:21
@quarkus-bot
Copy link

quarkus-bot bot commented Nov 20, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gsmet gsmet merged commit 7f0608d into quarkusio:main Nov 24, 2023
51 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.7 - main milestone Nov 24, 2023
@gsmet
Copy link
Member

gsmet commented Nov 24, 2023

Thanks!

@michalvavrik michalvavrik mentioned this pull request Dec 19, 2023
Closed
@michalvavrik michalvavrik deleted the feature/fix-tooltip-renderig-of-desc-with-paragraphs branch December 19, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins kind/bugfix
Projects
None yet
Milestone
3.7.0.CR1
Development

Successfully merging this pull request may close these issues.

Tooltips for enum values are rendered incorrectly in documentation of configuration properties
2 participants
@michalvavrik @gsmet