ArC: allow putting bean enablement annotations on stereotypes #37302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just realized I forgot to add something to the documentation. Will fix next week. EDIT: done. |
This comment has been minimized.
This comment has been minimized.
Ladicek
force-pushed
the
bean-enablement-on-stereotypes
branch
2 times, most recently
from
0a93546
to
7766662
Compare
|
I removed the support for custom stereotypes from this PR, which likely isn't a big deal, and it avoids a build step cycle. |
|
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
manovotn
approved these changes
Nov 28, 2023
...nsions/arc/deployment/src/main/java/io/quarkus/arc/deployment/BuildTimeEnabledProcessor.java
Show resolved
Hide resolved
mkouba
reviewed
Nov 28, 2023
...nsions/arc/deployment/src/main/java/io/quarkus/arc/deployment/BuildTimeEnabledProcessor.java
Outdated
Show resolved
Hide resolved
...nsions/arc/deployment/src/main/java/io/quarkus/arc/deployment/BuildTimeEnabledProcessor.java
Outdated
Show resolved
Hide resolved
...nsions/arc/deployment/src/main/java/io/quarkus/arc/deployment/BuildTimeEnabledProcessor.java
Outdated
Show resolved
Hide resolved
It would probably be best to write this algorithm in a lazy fashion (driven by the annotation transformation demands), but that would require breaking an extension API (specifically, it wouldn't be possible to produce `BuildTimeConditionBuildItem`). Hence, this commit enhances the eager algorithm for bean enablement scanning to also scan stereotypes, relying on subclass information in the Jandex index to support `@Inherited` stereotypes.
Ladicek
force-pushed
the
bean-enablement-on-stereotypes
branch
from
7766662
to
c197f41
Compare
|
@mkouba comments addressed. |
mkouba
approved these changes
Nov 28, 2023
mkouba
added
the
triage/waiting-for-ci
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
quarkus-bot
bot
added
kind/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would probably be best to write this algorithm in a lazy fashion (driven by the annotation transformation demands), but that would require breaking an extension API (specifically, it wouldn't be possible to produce
BuildTimeConditionBuildItem). Hence, this commit enhances the eager algorithm for bean enablement scanning to also scan stereotypes, relying on subclass information in the Jandex index to support@Inheritedstereotypes.Fixes #37117