Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comment about runtime initializing class for google cloud SQL #37339

Merged
merged 1 commit into from Nov 28, 2023
Merged

Add comment about runtime initializing class for google cloud SQL #37339

merged 1 commit into from Nov 28, 2023

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Nov 27, 2023

Closes #36996

@quarkus-bot quarkus-bot bot added this to To do in Quarkus Documentation Nov 27, 2023
@zakkak zakkak mentioned this pull request Nov 27, 2023
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2023 •
edited

🙈 The PR is closed and the preview is expired.

loicmathieu
loicmathieu approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Quarkus Documentation automation moved this from To do to Reviewer approved Nov 28, 2023
@zakkak
Copy link
Contributor Author

zakkak commented Nov 28, 2023

I addressed the linters comments as well.

@gsmet gsmet merged commit 79de27f into quarkusio:main Nov 28, 2023
5 checks passed
Quarkus Documentation automation moved this from Reviewer approved to Done Nov 28, 2023
@quarkus-bot quarkus-bot bot added this to the 3.7 - main milestone Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loicmathieu loicmathieu loicmathieu approved these changes

Assignees
No one assigned
Labels
area/documentation kind/bugfix
Projects
Quarkus Documentation
Done
Milestone
3.7.0.CR1
Development

Successfully merging this pull request may close these issues.

Native builds fail after upgrading to Quarkus 3.5.1, Mandrel 23.1.1.0-Final and Java 21
3 participants
@zakkak @loicmathieu @gsmet