Check native-tests.json/virtual-threads-tests.json in CI build #37377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
the
area/infra-automation
yrodiere
force-pushed
the
verify-native-tests-json
branch
from
65ff072
to
091f241
Compare
This comment has been minimized.
This comment has been minimized.
gsmet
approved these changes
Nov 29, 2023
|
I will rerun the test when the other PR is merged. |
yrodiere
force-pushed
the
verify-native-tests-json
branch
from
091f241
to
200f287
Compare
|
Thanks, we got hit by that too many time! |
|
Note this won't check whether some IT modules are not referenced at all in native-tests.json... I'm not even sure we can do that, as I expect some modules just don't need be tested in native mode? Anyway, I'll leave this as an exercise for the reader :] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this will spare us things like #37374 in the future
Tested locally, it did detect the problem solved by #37374 .