Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable retrying tests for Surefire #37612

Closed
wants to merge 1 commit into from

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Dec 8, 2023

Unfortunately, it doesn't seem that Failsafe can fail when there is a flaky test so for now only doing it for Surefire.

We will be able to generalize to Failsafe once we have the infrastructure to include the flaky tests in the reporting.

@jprinet it's what you had in mind, right?

@jprinet
Copy link
Contributor

jprinet commented Dec 8, 2023

My understanding @gsmet is that failsafe has the same capabilities to rerun failed tests and fail the goal if a flaky test is identified
https://maven.apache.org/surefire/maven-failsafe-plugin/examples/rerun-failing-tests.html#re-run-and-fail-the-build-upon-flaky-test-count

Besides that, yes the surefire setup looks good 👍

@quarkus-bot

This comment has been minimized.

@gsmet
Copy link
Member Author

gsmet commented Dec 11, 2023

@jprinet I had a look specifically here the other day: https://maven.apache.org/surefire/maven-failsafe-plugin/integration-test-mojo.html and failOnFlakeCount is not mentioned anywhere.

Also, just figured out that the report would be a lot less useful as it doesn't mention the test so I will need to figure this out before merging.

@quarkus-bot

This comment has been minimized.

@quarkus-bot
Copy link

quarkus-bot bot commented Dec 12, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gsmet
Copy link
Member Author

gsmet commented Dec 12, 2023

I created apache/maven-surefire#700 in the hopes that it could be merged relatively soon.

@gsmet
Copy link
Member Author

gsmet commented Feb 6, 2024

Addressed in another PR.

@gsmet gsmet closed this Feb 6, 2024
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants