Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve MongoDB tests on Java records #37624

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Improve MongoDB tests on Java records #37624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...-tests/mongodb-panache/src/main/java/io/quarkus/it/mongodb/panache/record/PersonName.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@

import io.quarkus.mongodb.panache.common.ProjectionFor;

@ProjectionFor(PersonWithRecord.class)
@ProjectionFor(PersonRecord.class)
public record PersonName(String firstName, String lastName) {
}
4 changes: 4 additions & 0 deletions ...ests/mongodb-panache/src/main/java/io/quarkus/it/mongodb/panache/record/PersonRecord.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
package io.quarkus.it.mongodb.panache.record;

public record PersonRecord(String firstName, String lastName, Status status) {
}
9 changes: 9 additions & 0 deletions ...db-panache/src/main/java/io/quarkus/it/mongodb/panache/record/PersonRecordRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
package io.quarkus.it.mongodb.panache.record;

import jakarta.enterprise.context.ApplicationScoped;

import io.quarkus.mongodb.panache.PanacheMongoRepository;

@ApplicationScoped
public class PersonRecordRepository implements PanacheMongoRepository<PersonRecord> {
}
16 changes: 8 additions & 8 deletions ...ts/mongodb-panache/src/main/java/io/quarkus/it/mongodb/panache/record/PersonResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,24 @@
package io.quarkus.it.mongodb.panache.record;

import java.net.URI;
import java.util.List;

import jakarta.inject.Inject;
import jakarta.ws.rs.GET;
import jakarta.ws.rs.POST;
import jakarta.ws.rs.Path;
import jakarta.ws.rs.core.Response;

@Path("/mongo/persons")
@Path("/persons/record")
public class PersonResource {
@Inject
PersonRecordRepository personRecordRepository;

@GET
public List<PersonName> getPersons() {
return PersonWithRecord.findAll().project(PersonName.class).list();
return personRecordRepository.findAll().project(PersonName.class).list();
}

@POST
public Response addPerson(PersonWithRecord person) {
person.persist();
String id = person.id.toString();
return Response.created(URI.create("/persons/entity/" + id)).build();
public void addPerson(PersonRecord person) {
personRecordRepository.persist(person);
}
}
9 changes: 0 additions & 9 deletions .../mongodb-panache/src/main/java/io/quarkus/it/mongodb/panache/record/PersonWithRecord.java
View file
Open in desktop

This file was deleted.

33 changes: 0 additions & 33 deletions ...db-panache/src/test/java/io/quarkus/it/mongodb/panache/record/MongodbPanacheRecordIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,40 +1,7 @@
package io.quarkus.it.mongodb.panache.record;

import static io.restassured.RestAssured.given;
import static io.restassured.RestAssured.when;
import static org.hamcrest.CoreMatchers.is;

import org.junit.jupiter.api.Test;

import io.quarkus.test.junit.QuarkusIntegrationTest;
import io.restassured.http.ContentType;

@QuarkusIntegrationTest
class MongodbPanacheRecordIT extends MongodbPanacheRecordTest {

private static final String ROOT_URL = "/mongo/persons";

@Test
void testRecordInPanache() {
var person1 = new PersonWithRecord();
person1.firstname = "Loïc";
person1.lastname = "Mathieu";
person1.status = Status.ALIVE;
var person2 = new PersonWithRecord();
person1.firstname = "Zombie";
person2.lastname = "Zombie";
person2.status = Status.DEAD;

given().body(person1).contentType(ContentType.JSON)
.when().post(ROOT_URL)
.then().statusCode(201);
given().body(person2).contentType(ContentType.JSON)
.when().post(ROOT_URL)
.then().statusCode(201);

when().get(ROOT_URL)
.then()
.statusCode(200)
.body("size()", is(2));
}
}
16 changes: 5 additions & 11 deletions ...-panache/src/test/java/io/quarkus/it/mongodb/panache/record/MongodbPanacheRecordTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,25 +15,19 @@
@QuarkusTestResource(MongoReplicaSetTestResource.class)
class MongodbPanacheRecordTest {

private static final String ROOT_URL = "/mongo/persons";
private static final String ROOT_URL = "/persons/record";

@Test
void testRecordInPanache() {
var person1 = new PersonWithRecord();
person1.firstname = "Loïc";
person1.lastname = "Mathieu";
person1.status = Status.ALIVE;
var person2 = new PersonWithRecord();
person1.firstname = "Zombie";
person2.lastname = "Zombie";
person2.status = Status.DEAD;
var person1 = new PersonRecord("Loïc", "Mathieu", Status.ALIVE);
var person2 = new PersonRecord("Zombie", "Zombie", Status.DEAD);

given().body(person1).contentType(ContentType.JSON)
.when().post(ROOT_URL)
.then().statusCode(201);
.then().statusCode(204);
given().body(person2).contentType(ContentType.JSON)
.when().post(ROOT_URL)
.then().statusCode(201);
.then().statusCode(204);

when().get(ROOT_URL)
.then()
Expand Down