Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Security JWT guide minor fixes #37755

Merged
merged 1 commit into from Dec 14, 2023

Conversation

michalvavrik
Copy link
Contributor

@michalvavrik michalvavrik commented Dec 14, 2023

I read and tested https://quarkus.io/version/main/guides/security-jwt and propose very minor changes:

  • there is a space between java.security. and Principal
  • JSR 250 annotations are now Jakarta Annotations
  • 401 response body is empty, thus dropping Not authorized
  • publicKey.pem needs to be treated in uniform fashion and later it is enclosed with code quotes
  • SecurityResource adding missing imports, dropping unused import and variable, adding throws clause, making secret constant (which it de-facto was)

https://quarkus.io/version/main/guides/security-jwt-build

  • smallrye.jwt.sign.key.location has sign() and innerSign() as code, while smallrye.jwt.sign.key has them as a plain text (and their are right next to each other) so I'd like it to be same

Copy link

github-actions bot commented Dec 14, 2023

🙈 The PR is closed and the preview is expired.

Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this clean up Michal

Quarkus Documentation automation moved this from To do to Reviewer approved Dec 14, 2023
@sberyozkin sberyozkin merged commit e189992 into quarkusio:main Dec 14, 2023
5 checks passed
Quarkus Documentation automation moved this from Reviewer approved to Done Dec 14, 2023
@quarkus-bot quarkus-bot bot added this to the 3.7 - main milestone Dec 14, 2023
@michalvavrik michalvavrik deleted the docs/smallrye-jwt-tweaks branch December 14, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants