Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jboss-logmanager to 3.0.4.Final #37865

Merged
merged 2 commits into from Dec 22, 2023
Merged

Conversation

dmlloyd
Copy link
Member

@dmlloyd dmlloyd commented Dec 20, 2023

Fixes #36919. Fixes #22844.

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins labels Dec 20, 2023
@quarkus-bot

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Dec 20, 2023

@dmlloyd the errors are probably related as I haven't see these failures before.

@dmlloyd
Copy link
Member Author

dmlloyd commented Dec 20, 2023

The failures do indeed look like they may be logging-related, though I don't see a change that might cause it.

@dmlloyd
Copy link
Member Author

dmlloyd commented Dec 20, 2023

java.util.logging.ErrorManager: 1: Handler publication threw an exception
java.lang.invoke.WrongMethodTypeException: expected (ExtLogRecord,long)LogRecord but found (ExtLogRecord,long)void
	at java.base/java.lang.invoke.Invokers.newWrongMethodTypeException(Invokers.java:523)
	at java.base/java.lang.invoke.Invokers.checkExactType(Invokers.java:532)
	at org.jboss.logmanager.ExtLogRecord.superSetLongThreadID(ExtLogRecord.java:692)
	at org.jboss.logmanager.ExtLogRecord.setLongThreadID(ExtLogRecord.java:711)
	at org.jboss.logmanager.ExtLogRecord.<init>(ExtLogRecord.java:137)

@dmlloyd
Copy link
Member Author

dmlloyd commented Dec 20, 2023

It's a regression: https://issues.redhat.com/browse/LOGMGR-344

I'll update this PR with 3.0.4.Final once the release is done (and the requisite time has elapsed).

@dmlloyd dmlloyd changed the title Update jboss-logmanager to 3.0.3.Final Update jboss-logmanager to 3.0.4.Final Dec 21, 2023
@dmlloyd
Copy link
Member Author

dmlloyd commented Dec 21, 2023

Should be OK now.

@quarkus-bot

This comment has been minimized.

@dmlloyd
Copy link
Member Author

dmlloyd commented Dec 21, 2023

I'll double check these failures.

@dmlloyd
Copy link
Member Author

dmlloyd commented Dec 21, 2023

Some (or maybe all) of these failures are due to usage of InMemoryHandler, which implements the JUL Handler API. Because of this, and the fix for #22844, the log manager auto-formats printf-style messages, causing tests which rely on the structure of log records to fail.

The simple workaround which I am testing now is for these handlers to extend ExtHandler instead, indicating that they can process printf-formatted records.

This avoids the situation where `printf`-formatted messages are translated to "simple" messages due to quarkusio#22844.
@quarkus-bot
Copy link

quarkus-bot bot commented Dec 21, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gsmet gsmet merged commit 86ee9b1 into quarkusio:main Dec 22, 2023
50 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.7 - main milestone Dec 22, 2023
@dmlloyd dmlloyd deleted the update-logmanager branch December 22, 2023 17:09
@gsmet gsmet modified the milestones: 3.7 - main, 3.6.5 Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/logging area/testing area/vertx kind/bugfix
Projects
None yet
2 participants