New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Access Log Configuration sample documentation for RESTEasy + Servlet #3792
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the file name
Hi Rostislav, which file must be renamed ? |
In case you can also configure another category such this: | ||
|
||
---- | ||
access-log(format='common', category='my.own.category') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Category is not recognized parameter
Caused by: java.lang.RuntimeException: Failed to start quarkus
at io.quarkus.runner.ApplicationImpl2.<clinit>(ApplicationImpl2.zig:131)
... 16 more
Caused by: java.lang.RuntimeException: java.lang.IllegalArgumentException: UT000045: Error parsing predicated handler string unknown parameter category:
access-log(format='common', category='my.own.category')
^
at io.quarkus.undertow.runtime.UndertowDeploymentRecorder.bootServletContainer(UndertowDeploymentRecorder.java:405)
at io.quarkus.deployment.steps.UndertowBuildStep$build37.deploy_0(UndertowBuildStep$build37.zig:444)
at io.quarkus.deployment.steps.UndertowBuildStep$build37.deploy(UndertowBuildStep$build37.zig:36)
at io.quarkus.runner.ApplicationImpl2.<clinit>(ApplicationImpl2.zig:117)
... 16 more
Caused by: java.lang.IllegalArgumentException: UT000045: Error parsing predicated handler string unknown parameter category:
access-log(format='common', category='my.own.category')
^
at io.undertow.server.handlers.builder.PredicatedHandlersParser.error(PredicatedHandlersParser.java:729)
at io.undertow.server.handlers.builder.PredicatedHandlersParser.handleHandlerNode(PredicatedHandlersParser.java:171)
at io.undertow.server.handlers.builder.PredicatedHandlersParser.handleNode(PredicatedHandlersParser.java:114)
at io.undertow.server.handlers.builder.PredicatedHandlersParser.parse(PredicatedHandlersParser.java:91)
at io.undertow.server.handlers.builder.PredicatedHandlersParser.parse(PredicatedHandlersParser.java:80)
at io.quarkus.undertow.runtime.UndertowHandlersConfServletExtension.handleDeployment(UndertowHandlersConfServletExtension.java:33)
at io.undertow.servlet.core.DeploymentManagerImpl.handleExtensions(DeploymentManagerImpl.java:300)
at io.undertow.servlet.core.DeploymentManagerImpl.deploy(DeploymentManagerImpl.java:155)
at io.quarkus.undertow.runtime.UndertowDeploymentRecorder.bootServletContainer(UndertowDeploymentRecorder.java:394)
... 19 more
|
Ok for the filename, I forgot the final "s". Regarding the configuration, I pasted there my current config, I also looked at the configuration builder and I read this: @Override
public Map<String, Class<?>> parameters() {
Map<String, Class<?>> params = new
params.put("format", String.class);
params.put("category", String.class);
return params;
} I'm using 0.21.1, but I can see that master version is without category. Should I document 0.21.1 or next version (the latter I think) ? |
Maybe missing category is a bug ... @masini docs in master should be relevant to master, but first I think we need to know more about missing |
What about this PR ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- This needs rebase because of onflicting files
- Is
category='my.own.category'
working now ? - I still see undertow-handler.conf (missing
s
for handlers)
Rebased required. |
I force-pushed a rebase and some adjustments. I think the category issue was fixed in Also, I don't know if this works without Undertow. If someone had the time to check, that would be nice. |
added comments to #4059 few days ago |
|
OK, then, it's good to go and we need to address access logs for Vert.x based RESTEasy. |
Few lines to describe how-to