Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Access Log Configuration sample documentation for RESTEasy + Servlet #3792

Merged
merged 2 commits into from Nov 25, 2019
Merged

Conversation

masini
Copy link
Contributor

@masini masini commented Aug 31, 2019

Few lines to describe how-to

Copy link
Member

@rsvoboda rsvoboda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the file name

@masini
Copy link
Contributor Author

masini commented Sep 2, 2019

Hi Rostislav, which file must be renamed ?

In case you can also configure another category such this:

----
access-log(format='common', category='my.own.category')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Category is not recognized parameter

Caused by: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.runner.ApplicationImpl2.<clinit>(ApplicationImpl2.zig:131)
	... 16 more
Caused by: java.lang.RuntimeException: java.lang.IllegalArgumentException: UT000045: Error parsing predicated handler string unknown parameter category:
access-log(format='common', category='my.own.category')
                                                     ^
	at io.quarkus.undertow.runtime.UndertowDeploymentRecorder.bootServletContainer(UndertowDeploymentRecorder.java:405)
	at io.quarkus.deployment.steps.UndertowBuildStep$build37.deploy_0(UndertowBuildStep$build37.zig:444)
	at io.quarkus.deployment.steps.UndertowBuildStep$build37.deploy(UndertowBuildStep$build37.zig:36)
	at io.quarkus.runner.ApplicationImpl2.<clinit>(ApplicationImpl2.zig:117)
	... 16 more
Caused by: java.lang.IllegalArgumentException: UT000045: Error parsing predicated handler string unknown parameter category:
access-log(format='common', category='my.own.category')
                                                     ^
	at io.undertow.server.handlers.builder.PredicatedHandlersParser.error(PredicatedHandlersParser.java:729)
	at io.undertow.server.handlers.builder.PredicatedHandlersParser.handleHandlerNode(PredicatedHandlersParser.java:171)
	at io.undertow.server.handlers.builder.PredicatedHandlersParser.handleNode(PredicatedHandlersParser.java:114)
	at io.undertow.server.handlers.builder.PredicatedHandlersParser.parse(PredicatedHandlersParser.java:91)
	at io.undertow.server.handlers.builder.PredicatedHandlersParser.parse(PredicatedHandlersParser.java:80)
	at io.quarkus.undertow.runtime.UndertowHandlersConfServletExtension.handleDeployment(UndertowHandlersConfServletExtension.java:33)
	at io.undertow.servlet.core.DeploymentManagerImpl.handleExtensions(DeploymentManagerImpl.java:300)
	at io.undertow.servlet.core.DeploymentManagerImpl.deploy(DeploymentManagerImpl.java:155)
	at io.quarkus.undertow.runtime.UndertowDeploymentRecorder.bootServletContainer(UndertowDeploymentRecorder.java:394)
	... 19 more

@rsvoboda
Copy link
Member

rsvoboda commented Sep 2, 2019

undertow-handler.conf
to
undertow-handlers.conf

@masini
Copy link
Contributor Author

masini commented Sep 2, 2019

Ok for the filename, I forgot the final "s".

Regarding the configuration, I pasted there my current config, I also looked at the configuration builder and I read this:

@Override
public Map<String, Class<?>> parameters() {

    Map<String, Class<?>> params = new 
    params.put("format", String.class);
    params.put("category", String.class);
    return params;
}

I'm using 0.21.1, but I can see that master version is without category.

Should I document 0.21.1 or next version (the latter I think) ?

@rsvoboda
Copy link
Member

rsvoboda commented Sep 3, 2019

Maybe missing category is a bug ...
@stuartwdouglas can you look at this ?

@masini docs in master should be relevant to master, but first I think we need to know more about missing category

@masini
Copy link
Contributor Author

masini commented Nov 5, 2019

What about this PR ?

@machi1990
Copy link
Member

@masini looks like there a conflicts, can you rebase on top of master? Thanks.

@rsvoboda do you mind having another look if the PR is okay for you? Thanks.

Copy link
Member

@rsvoboda rsvoboda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • This needs rebase because of onflicting files
  • Is category='my.own.category' working now ?
  • I still see undertow-handler.conf (missing s for handlers)

@machi1990 machi1990 added triage/needs-rebase This PR needs to be rebased first because it has merge conflicts area/documentation labels Nov 5, 2019
@cescoffier
Copy link
Member

Rebased required.

@gsmet
Copy link
Member

gsmet commented Nov 25, 2019

I force-pushed a rebase and some adjustments.

I think the category issue was fixed in quarkus-http. @rsvoboda could you see if you can still reproduce the issue?

Also, I don't know if this works without Undertow. If someone had the time to check, that would be nice.

@gsmet gsmet removed the triage/needs-rebase This PR needs to be rebased first because it has merge conflicts label Nov 25, 2019
@rsvoboda
Copy link
Member

added comments to #4059 few days ago

@rsvoboda
Copy link
Member

rsvoboda commented Nov 25, 2019

category worked for quarkus-http based app ...

@gsmet
Copy link
Member

gsmet commented Nov 25, 2019

OK, then, it's good to go and we need to address access logs for Vert.x based RESTEasy.

@gsmet gsmet dismissed rsvoboda’s stale review November 25, 2019 16:42

Comments addressed.

@gsmet gsmet merged commit cd893b3 into quarkusio:master Nov 25, 2019
@gsmet gsmet changed the title Added Access Log Configuration Sample Documentation Added Access Log Configuration sample documentation for RESTEasy + Servlet Nov 25, 2019
@gsmet gsmet added this to the 1.1.0 milestone Nov 25, 2019
@rsvoboda
Copy link
Member

@gsmet #5556
currently it has bug label, could be changed to enhancement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants