Verify duplicated context handling when caching a Uni #38035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cescoffier
force-pushed
the
add-cache-result-uni-dc-test
branch
from
c086d9a
to
44a7c93
Compare
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
geoand
approved these changes
Jan 4, 2024
rsvoboda
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
Approving, checked also on Quarkus main with reverted f781b7f and tests fails.
Thanks @cescoffier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test that properly verifies the handling of the duplicated context when caching Uni
This is related to the commit f781b7f.
Tests added in f5af6b4 were not reproducing the issue.
I kept these tests because they do test a few other things (but not the original issue).