Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Flyway to 10.10.0 #39509

Merged
merged 1 commit into from Mar 17, 2024
Merged

Update Flyway to 10.10.0 #39509

merged 1 commit into from Mar 17, 2024

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Mar 16, 2024

We will need an entry in the migration guide as they split the artifacts even more: flyway/flyway#3722 .

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/flyway labels Mar 16, 2024
@quarkus-bot

This comment has been minimized.

@quarkus-bot
Copy link

quarkus-bot bot commented Mar 17, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit a594515.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 devtools/cli

io.quarkus.cli.plugin.PluginCatalogServiceTest.shouldSyncWhenProjectFileIsNewerThanCatalog - History

  • expected: <true> but was: <false> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:31)
	at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:183)
	at io.quarkus.cli.plugin.PluginCatalogServiceTest.shouldSyncWhenProjectFileIsNewerThanCatalog(PluginCatalogServiceTest.java:109)

⚙️ JVM Tests - JDK 17 Windows

📦 extensions/websockets-next/server/deployment

io.quarkus.websockets.next.test.broadcast.BroadcastOnOpenTest.testLoMultiBidi - History

  • Messages: [c2] ==> expected: <true> but was: <false> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: Messages: [c2] ==> expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
	at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:214)
	at io.quarkus.websockets.next.test.broadcast.BroadcastOnOpenTest.assertBroadcast(BroadcastOnOpenTest.java:98)
	at io.quarkus.websockets.next.test.broadcast.BroadcastOnOpenTest.testLoMultiBidi(BroadcastOnOpenTest.java:50)

Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! I had this migration in my TODO list, thanks for looking into it

@gsmet gsmet merged commit dac2899 into quarkusio:main Mar 17, 2024
49 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.10 - main milestone Mar 17, 2024
@rsvoboda
Copy link
Member

rsvoboda commented Mar 19, 2024

Quickstarts are failing now @gsmet

org.acme.quartz.TaskResourceTest.tasks
Caused by: org.flywaydb.core.api.FlywayException: Unsupported Database: PostgreSQL 14.11
org.acme.hibernate.orm.FruitsEndpointTest.testListAllFruitsBaseSchema
Caused by: org.flywaydb.core.api.FlywayException: Unsupported Database: PostgreSQL 13.3

There is also nothing in migration guide for 3.10.

@rsvoboda
Copy link
Member

PR to fix QS: quarkusio/quarkus-quickstarts#1398

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants