Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the import of smallrye-common-bom higher up #39826

Merged

Conversation

aloubyansky
Copy link
Member

This is to make sure other BOMs don't accidentally bring in unexpected versions of smallrye-common-* before they are imported from smallrye-common-bom. The main branch looks good for now, however quarkus-bom:3.8.3 contains SmallRye Common 2.1.2 instead of the expected 2.2.0.

…OMs don't accidentally bring in unexpected versions of smallrye-common-*
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 2, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit bd65ef7.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 extensions/hibernate-orm/deployment

io.quarkus.hibernate.orm.HibernateHotReloadTestCase.testImportSqlWithContinuousTesting - History

  • Failed to wait for test run 3 State{lastRun=1, running=true, inProgress=false, run=1, passed=1, failed=0, skipped=0, isBrokenOnly=false, isTestOutput=false, isInstrumentationBasedReload=false, isLiveReload=true} - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Failed to wait for test run 3 State{lastRun=1, running=true, inProgress=false, run=1, passed=1, failed=0, skipped=0, isBrokenOnly=false, isTestOutput=false, isInstrumentationBasedReload=false, isLiveReload=true}
	at io.quarkus.test.ContinuousTestingTestUtils.waitForNextCompletion(ContinuousTestingTestUtils.java:44)
	at io.quarkus.hibernate.orm.HibernateHotReloadTestCase.testImportSqlWithContinuousTesting(HibernateHotReloadTestCase.java:87)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
Caused by: org.awaitility.core.ConditionTimeoutException: Condition returned by method "waitForNextCompletion" in class io.quarkus.test.ContinuousTestingTestUtils was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)

@gsmet gsmet merged commit 8f10e63 into quarkusio:main Apr 2, 2024
49 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.10 - main milestone Apr 2, 2024
@gsmet gsmet modified the milestones: 3.10 - main, 3.9.2 Apr 2, 2024
@gsmet gsmet modified the milestones: 3.9.2, 3.8.4 Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/smallrye triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants