Infinispan Cache Extension #39836

karesti · 2024-04-02T14:29:16Z

Deprecates custom annotations
Implements the cache extension SPI

Depends on #40038

...finispan-cache/deployment/src/test/java/io/quarkus/cache/infinispan/InfinispanCacheTest.java

...ns/infinispan-client/runtime/src/main/java/io/quarkus/infinispan/client/CacheInvalidate.java

geoand

I don't know a ton about the Infinispan implementation, but the integration with Quarkus seems to do what we are doing in Redis, so it makes sense

karesti · 2024-04-03T13:14:19Z

@gsmet Guillaume could your eyes give some light to this failure ? i've run the /update-extension-dependencies.sh script locally but there aren't more apparent changes needed and build still fails. I can't see what I'm missing here

.github/native-tests.json

cescoffier · 2024-04-12T06:30:08Z

...finispan-cache/deployment/src/test/java/io/quarkus/cache/infinispan/InfinispanCacheTest.java

+        Future<Uni<String>> thread1 = fork(() -> cache.get(id, key -> {
+            try {
+                barrier.await(10, TimeUnit.SECONDS);
+                barrier.await(10, TimeUnit.SECONDS);


this is a test coming from Spring Cache integration in the infinispan repo that tests the same logic. In order to avoid it to be a flaky test, as @jabolina explained to me, one is to first make sure we are inside the lambda, for line 189. The second to wait inside the lambda until we issue the second request on line 192

I would add that explanation in the code - because you can be sure I would ask the same question in 1 month... or one week, or even maybe tomorrow.

...finispan-cache/deployment/src/test/java/io/quarkus/cache/infinispan/InfinispanCacheTest.java

cescoffier · 2024-04-12T06:33:44Z

...pan-cache/runtime/src/main/java/io/quarkus/cache/infinispan/runtime/InfinispanCacheImpl.java

+
+    @Override
+    public Uni<Void> invalidate(Object key) {
+        return Uni.createFrom().completionStage(remoteCache.removeAsync(key));


That is not correct.
This invokes the "removeAsync" method immediately, and not at subscription time.

You need () -> removeCache.removeAsync(key)) (for all methods)

In addition, you may have to deal with the context, as your event is going to be emitted on a infinispan thread, which is not the caller context. At least add tests (the interceptor is likely going to do that already, but better verify).

There is a new integration test, what else should I add to test about the context ?

...pan-cache/runtime/src/main/java/io/quarkus/cache/infinispan/runtime/InfinispanCacheImpl.java

github-actions · 2024-04-16T12:46:24Z

🙈 The PR is closed and the preview is expired.

karesti · 2024-04-17T15:23:41Z

@cescoffier I pushed changes

cescoffier · 2024-04-21T13:18:04Z

...finispan-cache/deployment/src/test/java/io/quarkus/cache/infinispan/InfinispanCacheTest.java

+    @RegisterExtension
+    static final QuarkusUnitTest config = new QuarkusUnitTest()
+            .withEmptyApplication()
+            .withConfigurationResource("empty-application-infinispan-client.properties");


We may have a better way to create empty assets, but I can't remember the API.

cescoffier · 2024-04-21T13:19:13Z

...finispan-cache/deployment/src/test/java/io/quarkus/cache/infinispan/InfinispanCacheTest.java

+        Future<Uni<String>> thread1 = fork(() -> cache.get(id, key -> {
+            try {
+                barrier.await(10, TimeUnit.SECONDS);
+                barrier.await(10, TimeUnit.SECONDS);


I would add that explanation in the code - because you can be sure I would ask the same question in 1 month... or one week, or even maybe tomorrow.

karesti · 2024-04-22T13:39:57Z

@cescoffier I'm going to add the comment in the test and push.
Is there anything else preventing the merge at this point ?

* Deprecates custom annotations * Implements the cache extension SPI

quarkus-bot · 2024-04-22T14:08:33Z

Status for workflow `Quarkus Documentation CI`

This is the status report for running Quarkus Documentation CI on commit b6285a6.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

⚠️ There are other workflow runs running, you probably need to wait for their status before merging.

quarkus-bot · 2024-04-22T15:31:38Z

Status for workflow `Quarkus CI`

This is the status report for running Quarkus CI on commit b6285a6.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/websockets-next/server/deployment

✖ io.quarkus.websockets.next.test.openconnections.OpenConnectionsTest.testOpenConnections - History

Condition with Lambda expression in io.quarkus.websockets.next.test.utils.WSClient was not fulfilled within 10 seconds. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.websockets.next.test.utils.WSClient was not fulfilled within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.websockets.next.test.utils.WSClient.waitForMessages(WSClient.java:102)
	at io.quarkus.websockets.next.test.openconnections.OpenConnectionsTest.testOpenConnections(OpenConnectionsTest.java:69)

⚙️ JVM Tests - JDK 21

📦 extensions/websockets-next/server/deployment

✖ io.quarkus.websockets.next.test.openconnections.OpenConnectionsTest.testOpenConnections - History

Condition with Lambda expression in io.quarkus.websockets.next.test.utils.WSClient was not fulfilled within 10 seconds. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.websockets.next.test.utils.WSClient was not fulfilled within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.websockets.next.test.utils.WSClient.waitForMessages(WSClient.java:102)
	at io.quarkus.websockets.next.test.openconnections.OpenConnectionsTest.testOpenConnections(OpenConnectionsTest.java:69)

karesti · 2024-04-23T10:29:48Z

@geoand hey, do you spot anything missing at this point preventing the merge ?

geoand

LGTM

karesti requested a review from geoand April 2, 2024 14:29

quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/infinispan Infinispan labels Apr 2, 2024

quarkus-bot bot added this to To do in Quarkus Documentation Apr 2, 2024

karesti mentioned this pull request Apr 2, 2024

Infinispan cache annotations with Panache-Entity #29254

Open

karesti requested a review from wburns April 2, 2024 14:35

This comment has been minimized.

Sign in to view

karesti force-pushed the infinispan-cache-extension branch from 4634de7 to ce98f06 Compare April 2, 2024 16:10

This comment has been minimized.

Sign in to view

geoand reviewed Apr 3, 2024

View reviewed changes

...finispan-cache/deployment/src/test/java/io/quarkus/cache/infinispan/InfinispanCacheTest.java Outdated Show resolved Hide resolved

geoand reviewed Apr 3, 2024

View reviewed changes

...ns/infinispan-client/runtime/src/main/java/io/quarkus/infinispan/client/CacheInvalidate.java Outdated Show resolved Hide resolved

geoand reviewed Apr 3, 2024

View reviewed changes

karesti force-pushed the infinispan-cache-extension branch from ce98f06 to 1e336be Compare April 3, 2024 09:20

This comment has been minimized.

Sign in to view

karesti force-pushed the infinispan-cache-extension branch from 1e336be to 1af8976 Compare April 3, 2024 09:43

This comment has been minimized.

Sign in to view

karesti force-pushed the infinispan-cache-extension branch from 1af8976 to 9599407 Compare April 3, 2024 10:07

This comment has been minimized.

Sign in to view

karesti force-pushed the infinispan-cache-extension branch from 9599407 to 6d4e1bf Compare April 3, 2024 11:47

This comment has been minimized.

Sign in to view

gsmet force-pushed the infinispan-cache-extension branch from 6d4e1bf to b85c6d5 Compare April 3, 2024 13:22

This comment has been minimized.

Sign in to view

cescoffier requested changes Apr 12, 2024

View reviewed changes

karesti force-pushed the infinispan-cache-extension branch from 303597e to 9c58f8e Compare April 16, 2024 12:05

This comment has been minimized.

Sign in to view

karesti force-pushed the infinispan-cache-extension branch from 9c58f8e to 7c5f603 Compare April 16, 2024 13:38

This comment has been minimized.

Sign in to view

karesti force-pushed the infinispan-cache-extension branch from 7c5f603 to dad9166 Compare April 17, 2024 14:59

This comment has been minimized.

Sign in to view

cescoffier approved these changes Apr 21, 2024

View reviewed changes

Quarkus Documentation automation moved this from Review pending to Reviewer approved Apr 21, 2024

Infinispan Cache Extension

b6285a6

* Deprecates custom annotations * Implements the cache extension SPI

karesti force-pushed the infinispan-cache-extension branch from dad9166 to b6285a6 Compare April 22, 2024 13:43

cescoffier approved these changes Apr 22, 2024

View reviewed changes

geoand approved these changes Apr 23, 2024

View reviewed changes

geoand added the release/noteworthy-feature label Apr 23, 2024

geoand merged commit a3d1568 into quarkusio:main Apr 23, 2024
54 checks passed

Quarkus Documentation automation moved this from Reviewer approved to Done Apr 23, 2024

quarkus-bot bot added this to the 3.11 - main milestone Apr 23, 2024

quarkus-bot bot added kind/bugfix kind/enhancement New feature or request labels Apr 23, 2024

karesti deleted the infinispan-cache-extension branch April 23, 2024 11:33

karesti mentioned this pull request Apr 26, 2024

Infinispan cache example quarkusio/quarkus-quickstarts#1420

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Infinispan Cache Extension #39836

Infinispan Cache Extension #39836

karesti commented Apr 2, 2024 •

edited

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

geoand left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

karesti commented Apr 3, 2024

This comment has been minimized.

cescoffier Apr 12, 2024

karesti Apr 17, 2024 •

edited

cescoffier Apr 21, 2024

cescoffier Apr 12, 2024

karesti Apr 12, 2024

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Apr 16, 2024 •

edited

This comment has been minimized.

This comment has been minimized.

karesti commented Apr 17, 2024

This comment has been minimized.

This comment has been minimized.

cescoffier Apr 21, 2024

cescoffier Apr 21, 2024

karesti commented Apr 22, 2024

quarkus-bot bot commented Apr 22, 2024

quarkus-bot bot commented Apr 22, 2024 •

edited by github-actions bot

karesti commented Apr 23, 2024

geoand left a comment

Infinispan Cache Extension #39836

Infinispan Cache Extension #39836

Conversation

karesti commented Apr 2, 2024 • edited

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

geoand left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

karesti commented Apr 3, 2024

This comment has been minimized.

cescoffier Apr 12, 2024

Choose a reason for hiding this comment

karesti Apr 17, 2024 • edited

Choose a reason for hiding this comment

cescoffier Apr 21, 2024

Choose a reason for hiding this comment

cescoffier Apr 12, 2024

Choose a reason for hiding this comment

karesti Apr 12, 2024

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Apr 16, 2024 • edited

This comment has been minimized.

This comment has been minimized.

karesti commented Apr 17, 2024

This comment has been minimized.

This comment has been minimized.

cescoffier Apr 21, 2024

Choose a reason for hiding this comment

cescoffier Apr 21, 2024

Choose a reason for hiding this comment

karesti commented Apr 22, 2024

quarkus-bot bot commented Apr 22, 2024

Status for workflow Quarkus Documentation CI

quarkus-bot bot commented Apr 22, 2024 • edited by github-actions bot

Status for workflow Quarkus CI

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/websockets-next/server/deployment

⚙️ JVM Tests - JDK 21

📦 extensions/websockets-next/server/deployment

karesti commented Apr 23, 2024

geoand left a comment

Choose a reason for hiding this comment

karesti commented Apr 2, 2024 •

edited

karesti Apr 17, 2024 •

edited

github-actions bot commented Apr 16, 2024 •

edited

Status for workflow `Quarkus Documentation CI`

quarkus-bot bot commented Apr 22, 2024 •

edited by github-actions bot

Status for workflow `Quarkus CI`