Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.8] Prevent smallrye-graphql-schema-builder from leaking into runtime deps #40104

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

jmartisk
Copy link
Contributor

@jmartisk
Copy link
Contributor Author

Very strictly speaking it's a breaking change, but only if somebody uses the configuration object (SmallRyeGraphQLConfig) programmatically, which I think is not supported for applications?! But the benefit here is big, we get rid of the kotlin-stdlib and kotlinx-metadata-jvm dependencies in runtime.

@rsvoboda
Copy link
Member

rsvoboda commented Apr 16, 2024

Context for backports session: fixes kotlin part of https://issues.redhat.com/browse/QUARKUS-4078

@aloubyansky
Copy link
Member

FYI @gsmet, we'll want it in 3.8.4.

@gsmet gsmet changed the title (3.8) Prevent smallrye-graphql-schema-builder from leaking into runtime deps [3.8] Prevent smallrye-graphql-schema-builder from leaking into runtime deps Apr 16, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 16, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 96c3342.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
JVM Tests - JDK 17 Build Failures Logs Raw logs 🚧
✔️ JVM Tests - JDK 21 Logs Raw logs 🚧

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: integration-tests/grpc-descriptor-sets/grpc-descriptor-set-alternate-output-dir 

📦 integration-tests/grpc-descriptor-sets/grpc-descriptor-set-alternate-output-dir

io.quarkus.grpc.examples.hello.DescriptorSetExistsTest.descriptorSetExists line 16 - History - More details - Source on GitHub

java.lang.AssertionError: 

Expecting path:
  /home/runner/work/quarkus/quarkus/integration-tests/grpc-descriptor-sets/grpc-descriptor-set-alternate-output-dir/target/proto
to exist (symbolic links were followed).
	at io.quarkus.grpc.examples.hello.DescriptorSetExistsTest.descriptorSetExists(DescriptorSetExistsTest.java:16)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

@gsmet gsmet merged commit dc6e742 into quarkusio:3.8 Apr 16, 2024
47 of 48 checks passed
@gsmet
Copy link
Member

gsmet commented Apr 16, 2024

I'm not sure what's going on with this gRPC test failing. It has been failing a few times...

@gsmet gsmet added this to the 3.8.4 milestone Apr 16, 2024
@jmartisk jmartisk deleted the 3.8-graphql-runtime-deps branch April 16, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants