Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSockets Next: produce ExecutionModelAnnotationsAllowedBuildItem #40180

Merged
merged 1 commit into from Apr 22, 2024

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Apr 22, 2024

  • so that callback methods can be annotated with Blocking, NonBlocking and RunOnVirtualThread

- so that callback methods can be annotated with Blocking, NonBlocking
and RunOnVirtualThread
@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 22, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 22, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 8df1abe.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/websockets-next/server/deployment

io.quarkus.websockets.next.test.openconnections.OpenConnectionsTest.testOpenConnections - History

  • Condition with Lambda expression in io.quarkus.websockets.next.test.utils.WSClient was not fulfilled within 10 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.websockets.next.test.utils.WSClient was not fulfilled within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.websockets.next.test.utils.WSClient.waitForMessages(WSClient.java:102)
	at io.quarkus.websockets.next.test.openconnections.OpenConnectionsTest.testOpenConnections(OpenConnectionsTest.java:69)

@mkouba
Copy link
Contributor Author

mkouba commented Apr 22, 2024

The OpenConnectionsTest#testOpenConnections() failure looks suspicious but it's not caused by this commit - the develocity shows the first failure on 19th April, i.e. after #40146 was merged.

@mkouba mkouba merged commit 923e83d into quarkusio:main Apr 22, 2024
19 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 22, 2024
@quarkus-bot quarkus-bot bot added this to the 3.11 - main milestone Apr 22, 2024
@gsmet gsmet modified the milestones: 3.11 - main, 3.10.0 Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants