Fix accidental config breakage of quarkus.package.decompiler.* properties

[dmlloyd]

This was missed in #39295. Fixes #40272.

/cc @mkouba

[mkouba]

Oh, I didn't even know about the existence of ConfigCompatibility class!

This is intended to be a temporary and evolutionary solution to be replaced by generative remapping.

I think that it would deserve more attention even though it's a temporary solution.

[gsmet]

@dmlloyd slightly related to that, I'm not very happy about how we deprecated the package config properties:

• the warning is not really actionable: you get a list of various config properties, it's hard to understand what you really need to do to make the warning quiet. I can see how it might not be practical to put all the details there but see below.
• we need entries in the migration guide to explain how to fix the setup (especially on how to fix our default project template if you have generated your project pre-3.10 also for the decompiler properties): https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.10
• we need something in quarkus-updates to update the projects. I'm going to have a look in the next few days, hopefully in time for the 3.10 release.

[galderz]

I guess this fixes this right?

[INFO] --- quarkus-maven-plugin:999-SNAPSHOT:build (default) @ getting-started-reactive ---
[WARNING] [io.quarkus.deployment.configuration] Configuration property 'quarkus.package.vineflower.enabled' has been deprecated and replaced by: [quarkus.package.decompiler.enabled]
[WARNING] [io.quarkus.config] Unrecognized configuration key "quarkus.package.decompiler.enabled" was provided; it will be ignored; verify that the dependency extension for this configuration is set or that you did not make a typo

[dmlloyd]

@dmlloyd slightly related to that, I'm not very happy about how we deprecated the package config properties:

• the warning is not really actionable: you get a list of various config properties, it's hard to understand what you really need to do to make the warning quiet. I can see how it might not be practical to put all the details there but see below.

I agree to an extent, but other than creating a custom message for each detected usage I wasn't sure how I could do much more. Also imagine that this could be automated some day; how would we want to approach that? Do you want a custom message for each case, and if so, what should the message say? Now, it tells you which property is deprecated, and what properties to set in its place, so at least that gives a good starting point for looking in the docs.

• we need entries in the migration guide to explain how to fix the setup (especially on how to fix our default project template if you have generated your project pre-3.10 also for the decompiler properties): https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.10

OK, I can look into this.

• we need something in quarkus-updates to update the projects. I'm going to have a look in the next few days, hopefully in time for the 3.10 release.

OK, I'll see what I can figure out here.

[dmlloyd]

I guess this fixes this right?

[INFO] --- quarkus-maven-plugin:999-SNAPSHOT:build (default) @ getting-started-reactive ---
[WARNING] [io.quarkus.deployment.configuration] Configuration property 'quarkus.package.vineflower.enabled' has been deprecated and replaced by: [quarkus.package.decompiler.enabled]
[WARNING] [io.quarkus.config] Unrecognized configuration key "quarkus.package.decompiler.enabled" was provided; it will be ignored; verify that the dependency extension for this configuration is set or that you did not make a typo

Yes this change hides the second message.

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 21ce678.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

---

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/infinispan-cache/deployment

✖ io.quarkus.cache.infinispan.InfinispanCacheTest.testGetAsyncWithParallelCalls - History

• expected: "thread1" but was: "thread2" - org.opentest4j.AssertionFailedError

org.opentest4j.AssertionFailedError: 

expected: "thread1"
 but was: "thread2"
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499)