Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use toString for serializing enum form params in REST Client #40301

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Apr 26, 2024

@geoand geoand requested a review from cescoffier April 26, 2024 08:52
@geoand geoand changed the title Use toString for serializing enum form params Use toString for serializing enum form params in REST Client Apr 26, 2024
@gsmet
Copy link
Member

gsmet commented Apr 26, 2024

I find it a bit weird that we are using toString() for serialization, mostly because I could see it used for other purposes. I would have expected to either use name() or have to use a converter.

It's mandated by the JAX-RS spec or MicroProfile?

@geoand
Copy link
Contributor Author

geoand commented Apr 26, 2024

JAX-RS mandates this for parameters that are serialized and do not represent the whole body

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 26, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 730c2a5.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit 399ba31 into quarkusio:main Apr 26, 2024
27 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.11 - main milestone Apr 26, 2024
@gsmet gsmet modified the milestones: 3.11 - main, 3.10.1 May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rest Client @RestForm does not serialize enums like other parameter types
3 participants