Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always populate metrics uri in presence of auth failures #40308

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Apr 26, 2024

@geoand
Copy link
Contributor Author

geoand commented Apr 26, 2024

The reason I have not added a test is that surfacing the problem requires a different security setup than the one of the existing integration tests and I am not terribly happy about adding yet another maven module. If we do think it's important however, I can go ahead and add it.

@ebullient
Copy link
Contributor

The reason I have not added a test is that surfacing the problem requires a different security setup than the one of the existing integration tests and I am not terribly happy about adding yet another maven module. If we do think it's important however, I can go ahead and add it.

It would be nice to find someway to exercise the code path, especially as it is rare (and we're less likely to notice if we break it). This could mean that we should think about a different way to test security paths altogether.

@quarkus-bot

This comment has been minimized.

@geoand
Copy link
Contributor Author

geoand commented Apr 26, 2024

The reason I have not added a test is that surfacing the problem requires a different security setup than the one of the existing integration tests and I am not terribly happy about adding yet another maven module. If we do think it's important however, I can go ahead and add it.

It would be nice to find someway to exercise the code path, especially as it is rare (and we're less likely to notice if we break it). This could mean that we should think about a different way to test security paths altogether.

The only way is to add another integration test module

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 29, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit dcbcdbd.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit 3b6f5c3 into quarkusio:main Apr 29, 2024
51 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 29, 2024
@quarkus-bot quarkus-bot bot added this to the 3.11 - main milestone Apr 29, 2024
@geoand geoand deleted the #40305 branch April 29, 2024 08:39
@gsmet gsmet modified the milestones: 3.11 - main, 3.10.1 May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Micrometer URI templating does not apply for Forbidden requests
3 participants