Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pseudo code in writing-extensions guide does not match the description #40342

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Pseudo code in writing-extensions guide does not match the description #40342

merged 1 commit into from
Apr 29, 2024

Conversation

gaol
Copy link
Contributor

@gaol gaol commented Apr 29, 2024

Fixes: #40341

@gaol
[issue:40341] [Doc] pseudo code in writing-extensions guide does not …
f1bb65a 
…match the description

Signed-off-by: Lin Gao <lgao@redhat.com>
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 29, 2024

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@quarkus-bot quarkus-bot bot added this to To do in Quarkus Documentation Apr 29, 2024
@gaol gaol changed the title [issue:40341] [Doc] pseudo code in writing-extensions guide does not match the description Pseudo code in writing-extensions guide does not match the description Apr 29, 2024
gsmet
gsmet approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for taking the time to open a PR.

Quarkus Documentation automation moved this from To do to Reviewer approved Apr 29, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 29, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit f1bb65a.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 29, 2024 •
edited

🙈 The PR is closed and the preview is expired.

@gsmet gsmet merged commit 77bbe3a into quarkusio:main Apr 29, 2024
5 checks passed
Quarkus Documentation automation moved this from Reviewer approved to Done Apr 29, 2024
@quarkus-bot quarkus-bot bot added this to the 3.11 - main milestone Apr 29, 2024
@gsmet gsmet modified the milestones: 3.11 - main, 3.10.1 May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/documentation
Projects
Quarkus Documentation
Done
Milestone
3.10.1
Development

Successfully merging this pull request may close these issues.

[Doc] pseudo code in writing-extensions guide does not match the description
2 participants
@gaol @gsmet