-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quarkus REST - reuse CDI request context if it exists #40408
Conversation
I'll turn this into a regular PR to get full test coverage. @michalvavrik feel free to add the tests you mentioned straight into this PR. |
Hello @manovotn , thank you for prompt debugging, feedback and fix. I have prepared reproducer inside OpenAPI IT module (because that is where Quarkus REST and Reactive Routes already are, no better place I could find). I cannot push it to your PR, please just pickup the commit, refactor it to your liking and use it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do agree with the idea (and it's consistent with what other extensions are doing; e.g. reactive routes) but I don't feel qualified to comment on the implementation 🤷 .
Ah, I didn't realize. |
This comment has been minimized.
This comment has been minimized.
Failures are related. Those are SR CP tests asserting destruction of beans in a no-propagation scenario that now doesn't happen correctly. |
Status for workflow
|
My understanding is that this should be backported as far back as 3.8 as the original report is that 3.8.4 introduces the issue? |
I added the backport but please I'd like someone to confirm :). |
Yeah, that makes sense |
Related to: #40307
Allows reuse of existing CDI req. context if present and monitors if req. context was activated from within
AbstractResteasyReactiveContext
. Only performs cleanup if the context was initialized here.