Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build SecurityEventHelper lazily inside SecurityConstrainer as when static methods are secured the static interceptor is initialized during static init #40457

Conversation

michalvavrik
Copy link
Contributor

fixes: #40065

@michalvavrik michalvavrik changed the title Build SecurityEventHelper lazily due to static interceptors Build SecurityEventHelper lazily inside SecurityConstrainer as when static methods are secured the static interceptor is initialized during static init May 4, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented May 4, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit cca3872.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@sberyozkin
Copy link
Member

@michalvavrik Would you like Roberto to have a look too ?

@michalvavrik
Copy link
Contributor Author

@michalvavrik Would you like Roberto to have a look too ?

I think it is not necessary, but if @radcortez finds a time and review this PR, I'll appreciate it. Please wait till Monday EOB in order to give Roberto time.

@michalvavrik
Copy link
Contributor Author

hey @sberyozkin this PR could be possibly improved on main branch as we could detect beforehand whether the initialization happens during static init or runtime init and act accordingly (lazily helper or eager helper).

but considering this needs to be backported, it's better to keep changes as small as possible. I can make further improvements on the main sometimes later. my suggestion is to merge this one.

@sberyozkin sberyozkin merged commit a33ed90 into quarkusio:main May 6, 2024
51 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.11 - main milestone May 6, 2024
@michalvavrik michalvavrik deleted the feature/roles-allowed-static-method-initialization branch May 6, 2024 17:27
@gsmet gsmet modified the milestones: 3.11 - main, 3.10.1 May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.8.3 and Electron JDBC Security error - SRCFG00027: Could not find a mapping
4 participants