Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OIDC ID token verification failure message #40685

Merged

Conversation

sberyozkin
Copy link
Member

In #40523, I've attempted to improve the error message when both ID token and access token have to be verified, as part of the authorization code flow.

Before #40523, if the access token verification failed, users would see a confusing ID token verification failed... message.
So in #40523, I made sure that they would see a correct Access token verification failed... message.

Unfortunately, now, when the ID token verification fails, they'll see the same Access token verification failed... message which I've noticed only now.

So this PR fixes it and I've confirmed the correct error message is reported when the ID token verification fails and when the access token verification fails

@quarkus-bot
Copy link

quarkus-bot bot commented May 16, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit b1e31dd.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@sberyozkin sberyozkin merged commit 3eaef20 into quarkusio:main May 16, 2024
22 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.12 - main milestone May 16, 2024
@sberyozkin sberyozkin deleted the fix_id_token_verification_error_message branch May 16, 2024 21:23
@gsmet gsmet modified the milestones: 3.12 - main, 3.10.2 May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants