Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce container-image-podman extension #40729

Merged
merged 1 commit into from
May 23, 2024

Conversation

edeandrea
Copy link
Contributor

@edeandrea edeandrea commented May 20, 2024

Introduce a new container-image-podman extension. See the conversation history on #40699 for the details that were discussed between myself and @geoand .

Essentially this refactors the current container-image-docker extension and adds a common layer underneath and pulls lots of common functionality up to that new common layer. Then it adds a new container-image-podman extension on top of the common layer.

@quarkus-bot
Copy link

quarkus-bot bot commented May 20, 2024

/cc @gsmet (elasticsearch), @loicmathieu (elasticsearch), @yrodiere (elasticsearch)

@quarkus-bot quarkus-bot bot added this to To do in Quarkus Documentation May 20, 2024
@quarkus-bot

This comment has been minimized.

Copy link

github-actions bot commented May 20, 2024

🙈 The PR is closed and the preview is expired.

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@geoand geoand changed the title New container-image-podman extension Introduce container-image-podman extension May 21, 2024
@quarkus-bot quarkus-bot bot added area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation labels May 22, 2024
@quarkus-bot

This comment has been minimized.

@edeandrea edeandrea force-pushed the container-image-podman branch 2 times, most recently from 1b3f17c to f7ea4d5 Compare May 22, 2024 12:09
@edeandrea
Copy link
Contributor Author

Not sure why the documentation CI is failing. I didn't change any of the docs since the last build which succeeded. I did rebase from main, so maybe something there broke it?

@quarkus-bot

This comment has been minimized.

@geoand
Copy link
Contributor

geoand commented May 22, 2024

I did rebase from main, so maybe something there broke it?

cc @gsmet

@geoand
Copy link
Contributor

geoand commented May 22, 2024

#40775 was merged which hopefully fixes the doc issue

@edeandrea
Copy link
Contributor Author

#40775 was merged which hopefully fixes the doc issue

I just rebased from main again to pull this in.

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Quarkus Documentation automation moved this from To do to Reviewer approved May 22, 2024
@geoand geoand added release/noteworthy-feature and removed area/documentation area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins labels May 22, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented May 22, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit e39d84e.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

⚠️ There are other workflow runs running, you probably need to wait for their status before merging.

@quarkus-bot
Copy link

quarkus-bot bot commented May 22, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit e39d84e.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 integration-tests/reactive-messaging-kafka

io.quarkus.it.kafka.KafkaConnectorTest.testFruits - History

  • Assertion condition defined as a Lambda expression in io.quarkus.it.kafka.KafkaConnectorTest expected: <6> but was: <5> within 10 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a Lambda expression in io.quarkus.it.kafka.KafkaConnectorTest expected: <6> but was: <5> within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:790)
	at io.quarkus.it.kafka.KafkaConnectorTest.testFruits(KafkaConnectorTest.java:63)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)

@geoand geoand merged commit b3c7172 into quarkusio:main May 23, 2024
54 checks passed
Quarkus Documentation automation moved this from Reviewer approved to Done May 23, 2024
@quarkus-bot quarkus-bot bot added this to the 3.12 - main milestone May 23, 2024
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Create an extension for using podman to build container images
2 participants