Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance JBang Documentation with Configuration and Qute Template #41744

Merged
merged 1 commit into from
Jul 7, 2024

Conversation

cescoffier
Copy link
Member

The existing configuration section was not functional due to issue #30087. This commit addresses this by documenting alternative methods using application.properties or application.yaml, as recommended in issue #41739.

Additionally, integrating Qute templates was not straightforward. This commit adds a dedicated section to the JBang documentation, providing instructions on including and using Qute templates.

Fix #41740
Relates to #41739

The existing configuration section was not functional due to issue quarkusio#30087. This commit addresses this by documenting alternative methods using `application.properties` or `application.yaml`, as recommended in issue quarkusio#41739.

Additionally, integrating Qute templates was not straightforward. This commit adds a dedicated section to the JBang documentation, providing instructions on how to include and use Qute templates.
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 7, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 17dccdd.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Copy link
Contributor

@maxandersen maxandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. better to have the working setup documented until Q:CONFIG is possible to have working consistently.

Quarkus Documentation automation moved this from To do to Reviewer approved Jul 7, 2024
@cescoffier
Copy link
Member Author

Yes, we can revert once we have Q:CONFIG back.

@cescoffier cescoffier merged commit 7e98e77 into quarkusio:main Jul 7, 2024
5 checks passed
Quarkus Documentation automation moved this from Reviewer approved to Done Jul 7, 2024
@quarkus-bot quarkus-bot bot added this to the 3.13 - main milestone Jul 7, 2024
Copy link

github-actions bot commented Jul 7, 2024

🙈 The PR is closed and the preview is expired.

@cescoffier cescoffier deleted the jbang-qute-doc-improvements branch July 11, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

JBang + Qute - Where should be the templates?
2 participants