Add support for named lambda request handlers #4331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartwdouglas
force-pushed
the
named-lambdas
branch
from
e0f22fb
to
6633b50
Compare
evanchooly
reviewed
Oct 3, 2019
...mbda/deployment/src/main/java/io/quarkus/amazon/lambda/deployment/AmazonLambdaProcessor.java
Show resolved
Hide resolved
evanchooly
reviewed
Oct 3, 2019
| @@ -106,22 +102,23 @@ void bootstrap(BuildProducer<GeneratedResourceBuildItem> generatedResources) thr | |||
|
|
|||
| @BuildStep | |||
| @Record(ExecutionTime.RUNTIME_INIT) | |||
| public void servlets(List<AmazonLambdaBuildItem> lambdas, | |||
| public void processLambas(List<AmazonLambdaBuildItem> lambdas, | |||
evanchooly
approved these changes
Oct 3, 2019
|
On Fri, 4 Oct 2019 at 05:48, Justin Lee ***@***.***> wrote:
***@***.**** approved this pull request.
This makes sense so far. Looking at the tests in integration-tests, I see
they're still "powered" by undertow. should all that be updated to use the
vert.x/netty bits?\
No, this is just a test framework that emulates the AWS environment. It is
an internal thing that is not actually using Quarkus.
Stuart
… —
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4331?email_source=notifications&email_token=AACQG62RWA574CVYDFSJDWTQMZD75A5CNFSM4I45R5B2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCG2YNNY#pullrequestreview-297109175>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACQG6YIZXNSK5AC3OVCVUDQMZD75ANCNFSM4I45R5BQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3099