Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to GraalVM 19.2.1 #4653

Merged

Conversation

cescoffier
Copy link
Member

This is the update to GraalVM 19.2.1

The build won't pass until the artifacts are in maven central

@cescoffier cescoffier requested a review from gsmet October 18, 2019 08:57
@gastaldi
Copy link
Contributor

Seems to be a duplicate of #4639?

@gsmet
Copy link
Member

gsmet commented Oct 18, 2019

I closed mine because I'm adorable :).

@gastaldi gastaldi added this to the 0.26.0 milestone Oct 18, 2019
@gsmet gsmet modified the milestones: 0.26.0, 0.27.0 Oct 21, 2019
@gsmet
Copy link
Member

gsmet commented Oct 21, 2019

The Maven artifacts are still not there.

@gastaldi
Copy link
Contributor

@Sanne
Copy link
Member

Sanne commented Oct 28, 2019

Still only a draft? Looking forward to this...

@gsmet
Copy link
Member

gsmet commented Oct 28, 2019

@Sanne oracle/graal#1769

@Sanne
Copy link
Member

Sanne commented Oct 28, 2019

@Sanne oracle/graal#1769

ah ic, thanks @gsmet . Yet this was happening regularly in early days? The svm annotations rarely change, that's why we had our build system prepare to run the build with the older annotations, and yet build with the latest.

In case of such a micro update that might be fine to do again?

@gsmet
Copy link
Member

gsmet commented Oct 28, 2019

Yeah, tbh, at the beginning, I was expecting a quick reaction from the GraalVM team :). I always prefer to have the artifacts aligned to avoid potential weird issues.

This PR needs to be modified per George's comment. But yeah, maybe let's use the old artifacts for now and update later.

@cescoffier
Copy link
Member Author

Will work on it just after my current call.

@cescoffier cescoffier force-pushed the features/update-to-graalvm-19.2.1 branch from b529a0e to fa84855 Compare October 28, 2019 09:54
@cescoffier cescoffier marked this pull request as ready for review October 28, 2019 09:55
@cescoffier
Copy link
Member Author

I've done the requested changes.

@Sanne
Copy link
Member

Sanne commented Oct 28, 2019

Thanks, I'll test this locally as well with the expected VM versions.

@Sanne
Copy link
Member

Sanne commented Oct 28, 2019

I'm having native compilation failures of the vault module. I'll try with the older (current) version next..

@gsmet
Copy link
Member

gsmet commented Oct 28, 2019

@Sanne what's the status for you? Were the failures related to the Docker issue? It looks good from a CI point of view.

@Sanne
Copy link
Member

Sanne commented Oct 28, 2019

@gsmet I could not re-launch all native tests. It was doing fine and got quite far ahead in the process but then I had to suspend my workstation... I will resume it tomorrow, but if CI is fine with it I guess let's merge it.

@Sanne Sanne self-requested a review October 28, 2019 21:27
@Sanne Sanne merged commit 2226943 into quarkusio:master Oct 28, 2019
@cescoffier cescoffier deleted the features/update-to-graalvm-19.2.1 branch January 21, 2020 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants