Only execute Vault ITs if -Dtest-vault is specified #4933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Sanne this should fix the problem you reported. |
Sanne
reviewed
Oct 28, 2019
| @@ -75,7 +75,6 @@ | |||
| <plugin> | |||
| <groupId>io.quarkus</groupId> | |||
| <artifactId>quarkus-maven-plugin</artifactId> | |||
| <version>${project.version}</version> | |||
There was a problem hiding this comment.
isn't this reverting what you just blessed in #4843 ?
There was a problem hiding this comment.
The issue is only if the plugin is in a profile. If it is not in a profile, it's OK. That's why I haven't removed the version in the profile below.
|
If we ignore the maven plugin version I commented about, the other changes to indeed fix the build. Thanks! |
Sanne
approved these changes
Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4925