Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComponentsProviderGenerator - break getComponents into multiple methods #5077

Merged
merged 1 commit into from Oct 31, 2019

Conversation

@mkouba
Copy link
Contributor

mkouba commented Oct 31, 2019

@mkouba mkouba added this to the 0.28.0 milestone Oct 31, 2019
@mkouba mkouba requested review from stuartwdouglas and manovotn Oct 31, 2019
@stuartwdouglas stuartwdouglas merged commit 4d16d85 into quarkusio:master Oct 31, 2019
24 checks passed
24 checks passed
WIP Ready for review
Details
quarkusio.quarkus Build #20191031.32 succeeded
Details
quarkusio.quarkus (Build for Native Build JDK8 Linux) Build for Native Build JDK8 Linux succeeded
Details
quarkusio.quarkus (Maven Cache Linux Maven Repo) Maven Cache Linux Maven Repo succeeded
Details
quarkusio.quarkus (Maven Cache Windows Maven Repo) Maven Cache Windows Maven Repo succeeded
Details
quarkusio.quarkus (Native Tests amazon-dynamodb, amazon-lambda, amazon-lambda-http-it) Native Tests amazon-dynamodb, amazon-lambda, amazon-lambda-http-it succeeded
Details
quarkusio.quarkus (Native Tests artemis-core, artemis-jms, kafka) Native Tests artemis-core, artemis-jms, kafka succeeded
Details
quarkusio.quarkus (Native Tests elytron-resteasy, oidc, oidc-code-flow, vault-app, keycloak-authorization) Native Tests elytron-resteasy, oidc, oidc-code-flow, vault-app, keycloak-authorization succeeded
Details
quarkusio.quarkus (Native Tests elytron-security-oauth2, elytron-security, elytron-security-jdbc, elytron-undertow) Native Tests elytron-security-oauth2, elytron-security, elytron-security-jdbc, elytron-undertow succeeded
Details
quarkusio.quarkus (Native Tests flyway, hibernate-orm-panache, reactive-pg-client) Native Tests flyway, hibernate-orm-panache, reactive-pg-client succeeded
Details
quarkusio.quarkus (Native Tests hibernate-search-elasticsearch, narayana-stm, narayana-jta) Native Tests hibernate-search-elasticsearch, narayana-stm, narayana-jta succeeded
Details
quarkusio.quarkus (Native Tests infinispan-cache-jpa, infinispan-client) Native Tests infinispan-cache-jpa, infinispan-client succeeded
Details
quarkusio.quarkus (Native Tests jackson, jsonb, jgit, kogito, kubernetes-client) Native Tests jackson, jsonb, jgit, kogito, kubernetes-client succeeded
Details
quarkusio.quarkus (Native Tests jpa, jpa-postgresql, jpa-mysql, reactive-mysql-client) Native Tests jpa, jpa-postgresql, jpa-mysql, reactive-mysql-client succeeded
Details
quarkusio.quarkus (Native Tests jpa-h2, jpa-mariadb, jpa-mssql, jpa-derby) Native Tests jpa-h2, jpa-mariadb, jpa-mssql, jpa-derby succeeded
Details
quarkusio.quarkus (Native Tests main) Native Tests main succeeded
Details
quarkusio.quarkus (Native Tests mongodb-client, mongodb-panache, neo4j) Native Tests mongodb-client, mongodb-panache, neo4j succeeded
Details
quarkusio.quarkus (Native Tests resteasy-jackson, vertx, vertx-http, virtual-http) Native Tests resteasy-jackson, vertx, vertx-http, virtual-http succeeded
Details
quarkusio.quarkus (Native Tests spring-di, spring-web, spring-data-jpa) Native Tests spring-di, spring-web, spring-data-jpa succeeded
Details
quarkusio.quarkus (Native Tests tika, hibernate-validator, test-extension) Native Tests tika, hibernate-validator, test-extension succeeded
Details
quarkusio.quarkus (Run JVM Tests Linux JDK11 Build) Run JVM Tests Linux JDK11 Build succeeded
Details
quarkusio.quarkus (Run JVM Tests Linux JDK12 Build) Run JVM Tests Linux JDK12 Build succeeded
Details
quarkusio.quarkus (Run JVM Tests Run_TCKs) Run JVM Tests Run_TCKs succeeded
Details
quarkusio.quarkus (Run JVM Tests Windows JVM Build) Run JVM Tests Windows JVM Build succeeded
Details
Copy link
Contributor

manovotn left a comment

I know I am coming late but I did review it nonetheless.
It's a really good solution and as a side effect, it makes the generated class more readable IMO.
Let's see if someone can breach the method limit with that ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.