Remove Arc dead code #5146
Merged
Remove Arc dead code #5146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
approved these changes
Nov 3, 2019
| @@ -228,7 +228,7 @@ public InjectableContext getActiveContext(Class<? extends Annotation> scopeType) | |||
| public <T> InstanceHandle<T> instance(InjectableBean<T> bean) { | |||
| Objects.requireNonNull(bean); | |||
| requireRunning(); | |||
| return bean != null ? (InstanceHandle<T>) beanInstanceHandle(bean, null) : InstanceHandleImpl.unavailable(); | |||
| return (InstanceHandle<T>) beanInstanceHandle(bean, null); | |||
There was a problem hiding this comment.
Not exactly dead code but yes looks like the underlying method does the work for us.
There was a problem hiding this comment.
The removed condition always evaluated to true because of Objects.requireNonNull(bean); at the beginning of the method. That's why the removed code looks kind of dead to me :)
There was a problem hiding this comment.
Ah yes, sure, missed it. In any case beanInstanceHandle also deals with the null value so we are extra safe.
mkouba
approved these changes
Nov 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.