Log the dev mode JVM startup command at INFO level #5366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartwdouglas
approved these changes
Nov 11, 2019
stuartwdouglas
added
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dev mode JVM startup command is currently logged at
DEBUGlevel (in Maven DevMojo). I think logging this atINFOwill be more useful since it prints out useful information on what arguments etc are being passed to the JVM launch command. That can sometimes help identifying any obvious issues while debugging issues like #5359.Furthermore, this log message is logged only once when the JVM is launched. So I don't think changing this to INFO will end up polluting the logs.
BTW, the gradle version of dev mode already prints this detail at "INFO" level by using System.out.println.