New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Place json configuration files next to thin jar when building #5566
Conversation
I could add tests for these if you feel it's warranted, but they would of course slow down the build a lot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments
core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/JarResultBuildStep.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This makes it very easy and predicable to configure add extra json files to configure GraalVM natives. Furthermore, this makes these fails available to docker when a container build of the native image is being used. Fixes: quarkusio#5390
@gsmet are you ok with this one? |
I don't really like this solution. Even though it improves the status quo I still don't think it provides a great user experience. Maybe the approach should be:
I think we should discuss this, as the user should not have to mess around with JSON files or the substrate command line to include some resources in their image. |
@stuartwdouglas you have my vote when it comes to adding everything in This PR didn't really attempt to solve that problem generally. It was motivated primarily by the fact that currently one can't due a native build using docker and specify the json config files |
Even if we do add some dedicated configuration options for resource and reflection handling (plus whatever other json file could be added), we'll still need the copy mechanics of this PR. I do like the idea of having dedicated |
This makes it very easy and predicable to configure
add extra json files to configure GraalVM natives.
Furthermore, this makes these files available to
docker when a container build of the native image
is being used - something which fails without this change.
Fixes: #5390