Fix various JAXB issues #5568
Merged
Fix various JAXB issues #5568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XmlRootElement is optional so we need to trigger the JAXB inclusion with XmlType too.
This implementation is important and used by JAXB. We just need to register proxies for the combinations of JAXB annotations and Locatable.
|
@geoand could you have a look. I'm very tempted to backport it. Better reviewed commit per commit. |
|
Sure, I'll check it out right away |
|
@geoand btw, if you want the OP's test case to work, you have to remove all the occurrences of He added them when experimenting for solving the issue. |
|
I'll do that |
geoand
approved these changes
Nov 18, 2019
|
TCK failure is unrelated. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see what CI has to say as I can't build the main integration tests on my laptop anymore.
Fixes #5558