Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: use public inner class for reflection #6556

Merged
merged 1 commit into from Jan 14, 2020
Merged

doc: use public inner class for reflection #6556

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/src/main/asciidoc/validation.adoc
View file
Open in desktop
Expand Up @@ -128,7 +128,7 @@ Let's now create the `Result` class as an inner class:

[source, java]
----
private class Result {
public class Result {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also make it static. The quickstart is OK btw, I just checked it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, is it so? Making it public but not static just worked fine for me...am I missing something?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works but it's not optimal.


Result(String message) {
this.success = true;
Expand Down