Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component upgrades for JBoss Threads #6961

Merged
merged 2 commits into from Feb 4, 2020
Merged

Conversation

dmlloyd
Copy link
Member

@dmlloyd dmlloyd commented Feb 3, 2020

These component upgrades fix some potential thread pool scalability issues that show up on some CPU architectures.

This fixes a perf regression likely caused by false sharing that affects total throughput.  See https://issues.jboss.org/browse/JBTHR-71 for more information.
This should significantly improve performance of task dispatch on single-core systems while also making it possible to fine-tune performance of task dispatch elsewhere
@boring-cyborg boring-cyborg bot added the area/dependencies Pull requests that update a dependency file label Feb 3, 2020
@dmlloyd
Copy link
Member Author

dmlloyd commented Feb 3, 2020

See https://issues.jboss.org/browse/JBTHR-71 for more information about the change.

@gsmet
Copy link
Member

gsmet commented Feb 3, 2020

Triggered a rerun as the artifacts have been deployed on Central.

@dmlloyd
Copy link
Member Author

dmlloyd commented Feb 3, 2020

Did it fail when I didn't notice? I waited until both artifacts were on central before submitting the PR.

@gsmet
Copy link
Member

gsmet commented Feb 3, 2020

It failed in the Maven cache job, I haven't looked for the details. Let's see what happens with this one.

@dmlloyd
Copy link
Member Author

dmlloyd commented Feb 3, 2020

I couldn't find the historical build on Azure. I guess we'll see how this one goes.

@dmlloyd dmlloyd requested a review from gsmet February 3, 2020 15:48
@gsmet
Copy link
Member

gsmet commented Feb 3, 2020

At least the Maven cache job went well. Sometimes, there's a slight delay before all the Maven repo are synced so we might have had an issue with that.

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 3, 2020
@gsmet gsmet merged commit 9a1abca into quarkusio:master Feb 4, 2020
@gsmet gsmet added this to the 1.3.0.Alpha1 milestone Feb 4, 2020
@dmlloyd dmlloyd deleted the jbthr-3.0.1 branch February 4, 2020 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants