Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back EnvConfigSource that was removed by accident #7029

Merged
merged 1 commit into from Feb 6, 2020

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Feb 6, 2020

This fixes failing Quickstarts CI

@geoand geoand added this to the 1.3.0 milestone Feb 6, 2020
@geoand geoand requested a review from dmlloyd February 6, 2020 13:14
@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 6, 2020
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geoand I think we should migrate all the projects and quickstarts to use the new way of configuring things for native images.

That's definitely not something we want to break again. I know you had something in the works for that so +1 from me on this.

@geoand
Copy link
Contributor Author

geoand commented Feb 6, 2020

@gsmet unfortunately for the integration tests that would not have caught this issue because we use the container build type for the native deployment.

Regardless, we should definitely do what you propose.

@gsmet
Copy link
Member

gsmet commented Feb 6, 2020

Yeah, I'm still torn on whether we shoud move to using a proper GraalVM install or stick with containers when moving to GH actions. In the end we want to test both.

So I suppose the current situation with core on container and quickstarts on install is as good as it can be.

But yeah, we need to migrate massively to the new config.

@gsmet gsmet merged commit 6df5c5a into quarkusio:master Feb 6, 2020
@geoand geoand deleted the env-var-fix branch February 6, 2020 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config area/core triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants