Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Maven 3.6.3 in new projects #7253

Merged
merged 1 commit into from Feb 19, 2020
Merged

Use Maven 3.6.3 in new projects #7253

merged 1 commit into from Feb 19, 2020

Conversation

gastaldi
Copy link
Contributor

No description provided.

@gastaldi gastaldi added this to the 1.3.0 milestone Feb 18, 2020
@gastaldi gastaldi added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven labels Feb 18, 2020
@geoand
Copy link
Contributor

geoand commented Feb 18, 2020 •
edited

I think there are 3 instances of 3.6.2 in the code base and all should probably be updated

aloubyansky
aloubyansky approved these changes Feb 18, 2020
View reviewed changes
Copy link
Member

@aloubyansky aloubyansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also upgrade https://github.com/quarkusio/quarkus/blob/master/bom/runtime/pom.xml#L70 to 3.6.3 or something. We don't really have to be using the minimal supported version ourselves.

@gastaldi
Copy link
Contributor Author

@aloubyansky I agree. I'll try to provide another PR bumping that

@geoand I believe I replaced all the cases, the other instances seems to be generated from these properties I think

@geoand
Copy link
Contributor

geoand commented Feb 18, 2020

Indeed the 3rd one does seem to be in a generated file

@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 18, 2020
gsmet
gsmet previously requested changes Feb 18, 2020
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: is the Maven wrapper used by Quarkus itself 3.6.3? I think we should be consistent as we run the tests with it.

So I would also upgrade the wrapper if not already 3.6.3. Feel free to dismiss this review if it already is.

@gastaldi
Copy link
Contributor Author

@gsmet good catch. I updated the wrapper to comply with Maven 3.6.3 too.

@gastaldi gastaldi requested a review from gsmet February 18, 2020 12:56
@gsmet
Copy link
Member

gsmet commented Feb 18, 2020

Ah ah, so I killed two birds with one stone because I was thinking of the wrapper we have at the root of the Quarkus project :).

@gastaldi gastaldi dismissed gsmet’s stale review February 18, 2020 23:00

Changes addressed

@gsmet gsmet merged commit d3c7486 into quarkusio:master Feb 19, 2020
@gsmet
Copy link
Member

gsmet commented Feb 19, 2020

@gastaldi if you upgrade the maven-core properties, please also upgrade the wrapper used for Quarkus itself here: https://github.com/quarkusio/quarkus/blob/master/.mvn/wrapper/maven-wrapper.properties .

@gastaldi gastaldi deleted the propose_maven branch February 19, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloubyansky aloubyansky aloubyansky approved these changes

@geoand geoand geoand approved these changes

@gsmet gsmet Awaiting requested review from gsmet

Assignees
No one assigned
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.3.0.CR1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gastaldi @geoand @gsmet @aloubyansky