fixes #6948 (@Inject Injection into EntityListener not working) #7296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gastaldi
added
area/arc
gsmet
requested changes
Feb 20, 2020
|
As I said in #6948 (comment) I'd rather try to find a different solution. |
|
Closing since it's an ugly hack and not the correct solution, see #6948 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did some digging around and the (imho) root cause for this not working is that Quarkus uses the Arc CDI implementation that is lacking some features hibernate requires.
This PR is implements a BeanManager wrapper that emulates just enough for EntityListeners to work.
Also I added some quarkus-deployment code to at least prevent the EntityListener bean from being removed due to quarkus marking it as unused.
I consider this a more-or-less ugly hack... but this feature imho cannot reasonably be implemented without lots of programming/refactoring in hibernate.